feat(store): add bannedSeller label for stores
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
jef
previously approved these changes
Sep 21, 2020
| @@ -95,7 +95,8 @@ export const Amazon: Store = { | |||
| ], | |||
| labels: { | |||
| captcha: ['enter the characters you see below'], | |||
| outOfStock: ['currently unavailable', 'available from these sellers'] | |||
| outOfStock: ['currently unavailable', 'available from these sellers'], | |||
| bannedSeller: ['sports authentics', 'raccoon capitalist', 'gigaparts'] | |||
There was a problem hiding this comment.
Cool!
Let's make this an environment variable at some point as well!
jef
changed the title
bannedSeller label for Amazon (or other retailers if needed)bannedSeller label for stores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bannedSellerfor Amazon to reduce false-positives from scalpers. One potential was to only allow Amazon as a known seller, but with different vendors, and even different names for official Amazon retail, it would be just as difficult to track legitimate sales against scalpers. I figured banning known scalpers is probably safer than trying to anticipate known good sellers.try varying your search termstobandh.tssince there were a ton of 404 redirects coming up suddenly spamming the bot.error reaching the evga websitetoevga.tsto avoid false positives from another hug of death.Work around solution for #165 fixes #142
Testing
amazon.comas thebannedSellerand got the correct warn that a banned seller was detected.New dependencies
None