Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ldlc): adding ldlc french store #2037

Merged
merged 10 commits into from
Mar 2, 2021
Merged

feat(ldlc): adding ldlc french store #2037

merged 10 commits into from
Mar 2, 2021

Conversation

MrToshio
Copy link
Contributor

Description

Testing

New dependencies

@MrToshio MrToshio requested a review from jef as a code owner February 26, 2021 19:04
@MrToshio MrToshio changed the title Add scraping of RTX 3080 to the french website ldlc **feat** Add scraping of RTX 3080 to the french website ldlc Feb 26, 2021
@MrToshio MrToshio changed the title **feat** Add scraping of RTX 3080 to the french website ldlc feat Add scraping of RTX 3080 to the french website ldlc Feb 26, 2021
@MrToshio MrToshio changed the title feat Add scraping of RTX 3080 to the french website ldlc feat(ldlc): add new website Feb 26, 2021
@MrToshio MrToshio changed the title feat(ldlc): add new website feat(ldlc): adding ldlc french store Feb 26, 2021
jef
jef reviewed Feb 27, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Do you mind adding to the documentation?

Thanks!

@MrToshio
Copy link
Contributor Author

This is great! Do you mind adding to the documentation?

Thanks!

Oops, done! :-)

jef
jef previously approved these changes Mar 2, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's apply these changes and merge it in!

src/store/model/ldlc.ts Outdated
Comment on lines 7 to 8
container: '.stock-1',
text: ['en', 'stock'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
container: '.stock-1',
text: ['en', 'stock'],
container: '.stock',
text: ['stock'],

Perhaps we just take this change?

src/store/model/ldlc.ts Outdated Show resolved Hide resolved
src/store/model/ldlc.ts Outdated Show resolved Hide resolved
src/store/model/ldlc.ts Show resolved Hide resolved
@jef jef dismissed their stale review March 2, 2021 17:10

Mistake

jef and others added 6 commits March 2, 2021 12:10
@jef
Merge branch 'main' into main
d33744c
@MrToshio @jef
Update src/store/model/ldlc.ts
0f07381 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@MrToshio @jef
Update src/store/model/ldlc.ts
db9214c 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@MrToshio @jef
Update src/store/model/ldlc.ts
425d9b2 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@jef
Merge branch 'main' into main
f66017b
@jef
fix: bad quote
e2b984e
jef
jef approved these changes Mar 2, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you very much!

@jef jef merged commit a7be09d into jef:main Mar 2, 2021
@MrToshio
Copy link
Contributor Author

MrToshio commented Mar 2, 2021

Great! Thank you very much!

nonono, thank YOU very much! :D

aguilaair added a commit to aguilaair/streetmerchant that referenced this pull request Mar 2, 2021
@aguilaair
Revert "feat(store): add ldlc (FR) (jef#2037)"
4182815 
This reverts commit a7be09d.
@tirrorex
Copy link

Hello @MrToshio ,
can you confirm that the bot is only checking for 3080's?
If so i can make another pull request based on your code for 3070 and 3060ti

@jef
Copy link
Owner

jef commented Mar 15, 2021

Feel free to make a PR. Looks like it's only 3080s.

@MrToshio
Copy link
Contributor Author

Hello @MrToshio ,
can you confirm that the bot is only checking for 3080's?
If so i can make another pull request based on your code for 3070 and 3060ti

Hello, I confirm that I only added the 3080, but yeah feel free to add any other one you feel like adding, don't hesitate to contact me if you are other questions 👍

erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
@MrToshio @jef @erwinc1
feat(store): add ldlc (FR) (jef#2037)
10f4a98 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrToshio @tirrorex @jef