fix: gamestop false positives #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue where gamestop would generate false positives because the string add to cart was still included even when there was no stock available. Just added the outOfStock label to look for not available, which is actually displayed on the button.
jef
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where gamestop would generate false positives because the string add to cart was still included even when there was no stock available. Just added the outOfStock label to look for not available, which is actually displayed on the button.
Description
Fixes #392
Testing
Before the fix, as soon as I ran the bot, a notification would be created for gamestop having stock. After the fix, the info log note shows gamestop out of stock as well. Ran it for a at least 10 to 20 minutes with no issues.
Before
After
