feat: optional per store min and max page sleep time #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…settings (Some stores are more sensible to query interval than others)
jef
approved these changes
Oct 23, 2020
| @@ -128,7 +128,7 @@ Here is a list of variables that you can use to customize your newly copied `.en | |||
| | `SLACK_TOKEN` | Slack API token | | | |||
| | `SMTP_ADDRESS` | IP Address or fqdn of smtp server | | |||
| | `SMTP_PORT` | TCP Port number on which the smtp server is listening for connections | Default: `25` | | |||
| | `STORES` | [Supported stores](#supported-stores) you want to be scraped | Comma separated, default: `nvidia` | | |||
| | `STORES` | [Supported stores](#supported-stores) you want to be scraped | Both supported formats are comma separated <br/><br/>1. Standard E.g.: `"nvidia"` <br/><br/> 2. Advanced E.g: `STORE:PAGE_SLEEP_MIN:PAGE_SLEEP_MAX`, E.g: `nvidia:10000:30000` <br/><br/>Default: `nvidia` | | |||
There was a problem hiding this comment.
Suggested change
| | `STORES` | [Supported stores](#supported-stores) you want to be scraped | Both supported formats are comma separated <br/><br/>1. Standard E.g.: `"nvidia"` <br/><br/> 2. Advanced E.g: `STORE:PAGE_SLEEP_MIN:PAGE_SLEEP_MAX`, E.g: `nvidia:10000:30000` <br/><br/>Default: `nvidia` | | |
| | `STORES` | [Supported stores](#supported-stores) you want to be scraped | Both supported formats are comma separated<br/>1. Standard E.g.: `"nvidia"`<br/>2. Advanced E.g: `STORE:PAGE_SLEEP_MIN:PAGE_SLEEP_MAX`, E.g: `nvidia:10000:30000`<br/>Default: `nvidia` | |
I like the <br/>s! Maybe just one though per?
jef
changed the title
SesioN
added a commit
to SesioN/nvidia-snatcher
that referenced
this pull request
Oct 23, 2020
SesioN
added a commit
to SesioN/nvidia-snatcher
that referenced
this pull request
Oct 23, 2020
Merged
jef
pushed a commit
that referenced
this pull request
Oct 24, 2020
SesioN
referenced
this pull request
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for optional per store min and max page sleep time settings in the environment config file.
The per store settings override the main settings if provided.
Some stores are more sensible than others when it comes to blocking for too many queries over a period of time.
Testing
New dependencies