-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amd): add env vars and series filtering #696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update .env example - add MAX_PRICE_SERIES docs for AMD cpu's - add ryzen cpu's as defaults if SHOW_ONLY_SERIES is empty
njgreb
changed the title
missed AMD Ryzen additions
feat(amd): missed AMD Ryzen additions
Nov 5, 2020
Closed
…snatcher into amd-ryzen-updates
I think we'll also need to update this too: streetmerchant/src/store/lookup.ts Lines 161 to 185 in 5b3e95a
But I'll make a following push! Thanks for adding this in! :D |
jef
approved these changes
Nov 6, 2020
jef
changed the title
feat(amd): missed AMD Ryzen additions
feat(amd): add env vars and series filtering
Nov 6, 2020
jef
added a commit
that referenced
this pull request
Nov 6, 2020
Ref: #696 (comment) Signed-off-by: Jef LeCompte <jeffreylec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds env vars for price max on all AMD Ryzen Zen 3 cpus supported
Adds Zen 3 cpu's to the set of defaults if not filtered by config.