Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amd): add env vars and series filtering #696

Merged
merged 6 commits into from
Nov 6, 2020
Merged

Conversation

njgreb
Copy link
Contributor

@njgreb njgreb commented Nov 5, 2020

  • update .env example
  • add MAX_PRICE_SERIES docs for AMD cpu's
  • add ryzen cpu's as defaults if SHOW_ONLY_SERIES is empty

Description

Adds env vars for price max on all AMD Ryzen Zen 3 cpus supported
Adds Zen 3 cpu's to the set of defaults if not filtered by config.

- update .env example
- add MAX_PRICE_SERIES docs for AMD cpu's
- add ryzen cpu's as defaults if SHOW_ONLY_SERIES is empty
@njgreb njgreb requested a review from jef as a code owner November 5, 2020 23:02
@njgreb njgreb changed the title missed AMD Ryzen additions feat(amd): missed AMD Ryzen additions Nov 5, 2020
@njgreb njgreb mentioned this pull request Nov 5, 2020
@jef
Copy link
Owner

jef commented Nov 6, 2020

I think we'll also need to update this too:

if (store.labels.maxPrice) {
let price;
let maxPrice = 0;
switch (link.series) {
case '3070':
price = await cardPrice(page, store.labels.maxPrice, config.store.maxPrice.series['3070'], baseOptions);
maxPrice = config.store.maxPrice.series['3070'];
break;
case '3080':
price = await cardPrice(page, store.labels.maxPrice, config.store.maxPrice.series['3080'], baseOptions);
maxPrice = config.store.maxPrice.series['3080'];
break;
case '3090':
price = await cardPrice(page, store.labels.maxPrice, config.store.maxPrice.series['3090'], baseOptions);
maxPrice = config.store.maxPrice.series['3090'];
break;
default:
break;
}
if (price) {
logger.info(Print.maxPrice(link, store, price, maxPrice, true));
return false;
}
}

But I'll make a following push! Thanks for adding this in! :D

@jef jef changed the title feat(amd): missed AMD Ryzen additions feat(amd): add env vars and series filtering Nov 6, 2020
@jef jef merged commit df3b10b into jef:main Nov 6, 2020
jef added a commit that referenced this pull request Nov 6, 2020
Ref: #696 (comment)
Signed-off-by: Jef LeCompte <jeffreylec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants