Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add vsgamers #767

Merged
merged 23 commits into from
Nov 21, 2020
Merged

feat(store): add vsgamers #767

merged 23 commits into from
Nov 21, 2020

Conversation

crstian19
Copy link
Contributor

Description

Testing

New dependencies

@crstian19 crstian19 requested a review from jef as a code owner November 11, 2020 17:10
@jef jef changed the base branch from develop to main November 12, 2020 13:38
jef
jef requested changes Nov 12, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for contributing. I'd rather not maintain a docker-compose.yaml file at this time.

Otherwise, looks good! Just need to fix the linting.

src/store/model/index.ts Outdated Show resolved Hide resolved
crstian19 and others added 2 commits November 12, 2020 20:07
@crstian19 @jef
Update src/store/model/index.ts
03c4d49 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@crstian19
Update linting
4e20369
@crstian19 crstian19 requested a review from jef November 14, 2020 17:13
@jef
Copy link
Owner

jef commented Nov 21, 2020

Thank you!

@jef jef changed the title feat(store): Add Vsgamers Spanish Store feat(store): add vsgamers Nov 21, 2020
@jef jef merged commit 53739e0 into jef:main Nov 21, 2020
@makiisthenes makiisthenes mentioned this pull request Jun 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crstian19 @jef