Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept incomplete information as Discord status #358

Closed
Trapigtrogen opened this issue Nov 4, 2023 · 1 comment · Fixed by #359
Closed

Accept incomplete information as Discord status #358

Trapigtrogen opened this issue Nov 4, 2023 · 1 comment · Fixed by #359
Labels
bug Something isn't working

Comments

@Trapigtrogen
Copy link
Contributor

Trapigtrogen commented Nov 4, 2023

Expected Behavior

Discord status should show what I'm playing even with missing information

Current Behavior

If current song doesn't have all needed information, Discord status freezes to previous song or doesn't start if no proper song was played previously.

Steps to Reproduce

  1. Optionally play song that shows in Discord status

  2. Play song without album information

  3. Discord is showing previous song info with 0 seconds left or no information if song without album was the first thing played

Context

Playing downloaded music from YouTube or other unofficial source that doesn't have all the metadata. Metadata also has not been found by lidarr of jellyfin. For example any of these unofficially remastered Moomin music don't have metadata anywhere https://open.spotify.com/album/66SQzT6zdfqm9Bt61kEcfW

I think it's because of the src/renderer/features/discord-rpc/use-discord-rpc.ts line 34 where the artists are mapped. What if there's no artists? I couldn't get the thing built so couldn't confirm myself

  • Application version (e.g. v0.1.0) : 0.5.1
  • Operating System and version (e.g. Windows 10) : Arch Linux
  • Server and version (e.g. Navidrome v0.48.0) : Jellyfin 10.8.11
  • Node version (if developing locally) : -
@Trapigtrogen Trapigtrogen added the bug Something isn't working label Nov 4, 2023
@Trapigtrogen
Copy link
Contributor Author

I got it built and it showed the info raw
So made PR while at it

@jeffvli jeffvli linked a pull request Nov 12, 2023 that will close this issue
@jeffvli jeffvli closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants