-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media keys status do not reflect in the app #476
Comments
I just tried to disable |
I was about to write up a bug report for this. Glad I'm not the only one experiencing it. Thanks for writing this up @akelge! |
Not seeing this issue with either mpv or web on the latest commit (on Windows and Arch). |
I am able to reproduce this on Ventura (13.5.2) with MPV backend. What I suspect is happening is that the pause/play event is going. It looks like for MPV the play-pause is going to MPV (and not caught by Feishin), whereas for web (at least in my case), Feishin isn't capturing it at all |
For MacOS (13/14) it is required to be a trusted accessibility client (https://www.electronjs.org/docs/latest/api/system-preferences#systempreferencesistrustedaccessibilityclientprompt-macos) before it will allow controlling via media keys. In the case of MPV, without this the pause/play are going directly to MPV and bypassinf Feishin. I'll add a prompt when enabling shortcuts |
Expected Behavior
Pressing the play/pause key on my keyboard should make Feishin change state and the play/pause button in the bottom play bar should reflect the status of the application, same goes for the window title, that should add
(Paused)
when the app switch to pause mode and remove(Paused)
when the app start playing musicCurrent Behavior
When I press the play/pause key, Feishin behaves correctly, but the play/pause button inside the application does not reflect the current status.
If Feishin was playing the play/pause button remains with the pause symbol (||), and the other way around. Also the window title does not change to
(Paused)
when pausing or does not remove(Paused)
when starting to play again.Steps to Reproduce
Press play button in the bottom bar, music starts playing;
Press play/pause key on mac keyboard, music pauses;
Play/pause button in the bottom bar remains with pause symbol;
(Paused)
is not added to the title bar;Possible Solution (Not obligatory)
I suspect that Feishin appearance is not in sync with the actual status
Context
Apparently this is not a big deal, but if I pause using the keyboard and then I wish to start play using the application, I have to press twice on the play/pause button, once to set it to play icon, then another time to actually start playing.
Your Environment
The text was updated successfully, but these errors were encountered: