Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPV playback does not work with multiple users #622

Closed
ChiliEater opened this issue May 20, 2024 · 0 comments · Fixed by #627
Closed

MPV playback does not work with multiple users #622

ChiliEater opened this issue May 20, 2024 · 0 comments · Fixed by #627
Labels
bug Something isn't working

Comments

@ChiliEater
Copy link

Expected Behavior

If I start two instances of Feishin with MPV playback enabled, I should be able to use both instances without issue.

Current Behavior

The first instance of Feishin creates an MPV socket at /tmp/node-mpv.sock using the current user's permission:

srw------- 1 chili chili 0 Mai 20 21:46 /tmp/node-mpv.sock=

Subsequent instances of Feishin from different users (for example pepper) are unable to start playback using MPV since they do not own the socket and are unable to re-create or access it.

Furthermore, Feishin does not clean up after itself when closing and the socket lingers until /tmp is cleared.

Steps to Reproduce

  1. Launch Feishin as user chili (example)
  2. Start playback
  3. Close Feishin
  4. Log in as user pepper (example)
  5. Launch Feishin
  6. Start playback
  7. Playback does not start

Possible Solution

In src/main/features/core/player/index.ts:92 the extra constant is created which is the appended to the socket name. This could be re-used to add some unique identifier to the name, i.e. username, random string, etc.

Context

No response

Application version

0.7.2

Operating System and version

Arch Linux, feishin-bin package from AUR

Server and Version

Navidrome 0.51.1

Node Version (if developing locally)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant