Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get cibuild-ruby to pass (:URLable data files knows the API URL) #430

Closed
DougBeney opened this issue Nov 14, 2017 · 6 comments
Closed
Labels

Comments

@DougBeney
Copy link

DougBeney commented Nov 14, 2017

Description:

I am trying to follow the Jekyll Admin Development instructions, however the cibuild-ruby script will not pass.

Tell us a bit about yourself:

  • Version of JekyllAdmin I'm using 0.7.0
  • Version of Jekyll I'm using 3.6.2
  • Version of NodeJS I'm using 8.8.1
  • Operating System: Ubuntu 17.10

Steps to reproduce:

1.) git clone https://github.com/jekyll/jekyll-admin && cd jekyll-admin
2.) ./script/bootstrap
3.) ./script/cibuild

On a vagrant VM:

The same problem seems to happen on a Vagrant VM.

Step 1.) vagrant init ubuntu/trusty64
Step 2.) vagrant up
Step 3.) vagrant ssh
Step 4.) Run the following commands to install git, NPM/Node, RVM/Ruby, Jekyll, and Bundler:

# Install git
sudo apt install git

# Install NPM/Node
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.6/install.sh | bash
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm
nvm install node

# Install RVM/Ruby
gpg --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 7D2BAF1CF37B13E2069D6956105BD0E739499BDB
\curl -sSL https://get.rvm.io | bash -s stable --ruby
source /home/vagrant/.rvm/scripts/rvm

# Install Jekyll and Bundler
gem install jekyll bundler

Step 5.) git clone https://github.com/jekyll/jekyll-admin && cd jekyll-admin
Step 6.) ./script/bootstrap
Step 7.) ./script/cibuild

I expected the following:

The build to succeed.

But got the following, instead:

Failures:

  1) JekyllAdmin::URLable data files knows the API URL
     Failure/Error: expect(subject.api_url).to eql(api_url)
     
       expected: "http://localhost:4000/_api/data/data_file.yml"
            got: "http://localhost:4000/_api/data/movies/genres/fiction.yml"
     
       (compared using eql?)
     # ./spec/jekyll-admin/urlable_spec.rb:101:in `block (3 levels) in <top (required)>'

Finished in 25.33 seconds (files took 0.73573 seconds to load)
203 examples, 1 failure

Failed examples:

rspec ./spec/jekyll-admin/urlable_spec.rb:100 # JekyllAdmin::URLable data files knows the API URL

Other details:

During the bootstrap script, I didn't notice any errors on the Ruby side of things. With NPM, fsevents didn't install, but I don't believe that would affect Ruby. Plus, fsevents was listed as an optional dependency.

I also want to note that if I run the ./script/build script and then try to use this Gem source in my Jekyll site, it will work perfectly as expected. But I still can't get it to pass the cibuild-ruby test.

@ashmaroli
Copy link
Member

The cibuild-ruby script passed that last time it was run on master.
When you run the server-frontend script and go to /admin/data what do you see,,?

@DougBeney
Copy link
Author

DougBeney commented Nov 14, 2017

server-frontend appears to show up perfectly. No errors in the terminal either.

./script/test-server works too once I run the build script.

@ashmaroli
Copy link
Member

server-frontend appears to show up perfectly

I mean do you see data_file.yml before the movies folder or the folder before the file?

@DougBeney
Copy link
Author

data_file.yml is in the test site's data directory if that is what you mean. Then, in that data folder, the movies folder does exist.

@DougBeney
Copy link
Author

Interesting. I just attempted this using a Vagrant VM and got the same error. Going to update the error reproduction steps with more info.

@jekyllbot
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants