Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no implicit conversion of nil into String in title #207

Closed
parkr opened this issue May 5, 2017 · 2 comments
Closed

no implicit conversion of nil into String in title #207

parkr opened this issue May 5, 2017 · 2 comments
Labels
frozen-due-to-age has-pull-request

Comments

@parkr
Copy link
Member

parkr commented May 5, 2017

This line:

jekyll-seo-tag/lib/jekyll-seo-tag/drop.rb

Line 45 in 96b1fa2

site_title + TITLE_SEPARATOR + format_string(site["description"])
does:

site_title + TITLE_SEPARATOR + format_string(site["description"])

One of those three is nil. Can we cast them all to a string or do a [...].compact.join("")?
@pathawks
Copy link
Member

pathawks commented May 5, 2017

See also #206

@pathawks
Copy link
Member

pathawks commented May 5, 2017

Fixed by #206

@pathawks pathawks closed this as completed May 5, 2017
@jekyll jekyll locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age has-pull-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parkr @pathawks @jekyllbot