Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use gems config key for Jekyll < 3.5.0 #245

Closed
6 tasks
first-timers bot opened this issue Nov 4, 2017 · 5 comments Β· Fixed by #255
Closed
6 tasks

Docs: Use gems config key for Jekyll < 3.5.0 #245

first-timers bot opened this issue Nov 4, 2017 · 5 comments Β· Fixed by #255

Comments

@first-timers
Copy link

first-timers bot commented Nov 4, 2017

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸŽƒπŸ’»πŸ‘• Hacktoberfest: Trick or Treat!

If you haven’t yet, sign up for Hacktoberfest to earn an exclusive T-Shirt. Plus I’m sure we can teach you a cool trick or two in the process

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file docs/installation.md in the jekyll-seo-tag repository (press the little pen Icon) and edit the line as shown below.

@@ -13,6 +13,8 @@
     - jekyll-seo-tag
 
:bulb: If you are using a Jekyll version less than `3.5.0`, use the `gems` key instead of `plugins`.
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@seafr
Copy link
Contributor

seafr commented Dec 11, 2017

Hi, I'd like to claim this issue. Thank you.

@DirtyF
Copy link
Member

DirtyF commented Dec 11, 2017

@seafr πŸ‘

Make sure to add backticks to the keys:

πŸ’‘ If you are using a Jekyll version less than 3.5.0, use the `gems` key instead of `plugins`.

@seafr
Copy link
Contributor

seafr commented Dec 11, 2017

I did. And for the version number too. So far, it looks ok. Please see https://github.com/seafr/jekyll-seo-tag/blob/first-timers-label/docs/installation.md

@DirtyF
Copy link
Member

DirtyF commented Dec 11, 2017

Add the πŸ’‘, open a pull request, and we're good πŸ‘Œ

@seafr
Copy link
Contributor

seafr commented Dec 11, 2017

Done. Thank you.

@DirtyF DirtyF closed this as completed Dec 11, 2017
@jekyll jekyll locked and limited conversation to collaborators May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants