Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle track selection not taking effect from Integrated Player #1017

Closed
1 of 3 tasks
silentTeee opened this issue Apr 10, 2023 · 7 comments · Fixed by #1021
Closed
1 of 3 tasks

Subtitle track selection not taking effect from Integrated Player #1017

silentTeee opened this issue Apr 10, 2023 · 7 comments · Fixed by #1021
Labels
bug Something isn't working

Comments

@silentTeee
Copy link

Describe the bug

  1. Begin playing file with at least one subtitle track, with none selected
  2. While playing the video, use the UI to change to one track.
  3. Observe the current setting not take effect.

In comparison, back out of the video and apply the Subtitle track setting from the synopsis page and begin playback again, which will work.

Audio track selection from the player appears to work fine for files with multiple supported streams.

Logs

No response

Application version

2.5.0-beta.3

Where did you install the app from?

Sideloaded APK (proprietary build)

Device information

Google Pixel 7

Android version

Android 13

Jellyfin server version

10.8.9 stable

Which video player implementations does this bug apply to?

  • Web player (default)
  • Integrated player (ExoPlayer)
  • External player (VLC, mpv, MX Player)
@silentTeee silentTeee added the bug Something isn't working label Apr 10, 2023
@silentTeee
Copy link
Author

It might be worth mentioning that every time I try to apply a new subtitle setting from within the player, after tapping the radio button once and witnessing the prompt close, if I open it again, the radio button that is highlighted is for the previous selection. But if press it again, the UI element will change when I check it for the third time, but it still won't be applied.

@Maxr1998
Copy link
Member

Could you add some more information on the media you're trying to stream?

Also, are you direct playing or transcoding?

@silentTeee
Copy link
Author

silentTeee commented Apr 10, 2023

Of course! Below is the metadata for just one file I tested with, I can reproduce this bug with files that use PGS-based subtitles as well. Without subtitles on, the info bubble reports I'm "DirectPlay", and once I get them to properly show up, the info bubble reports "Transcoding".

My Bride is a Mermaid - S01E11
Container: mkv
Size: 200 MB

Video
Title: 720p HEVC SDR
Codec: HEVC
Profile: Main 10
Level: 93
Resolution: 1280x720
Aspect ratio: 16:9
Interlaced: No
Framerate: 23.976025
Bitrate: 1153 kbps
Bit depth: 10 bit
Video range: SDR
Video range type: SDR
Pixel format: yuv420p10le
Ref frames: 1

Audio
Title: English - AAC - Stereo - Default
Language: eng
Codec: AAC
Profile: LC
Layout: stereo
Channels: 2 ch
Bitrate: 91 kbps
Sample rate: 48000 Hz
Default: Yes
Forced: No
External: No

Subtitle
Title: Signs/Songs (Doki) - English - Default - ASS
Language: eng
Codec: ASS
Default: Yes
Forced: No
External: No

Audio
Title: Japanese - AAC - Stereo
Language: jpn
Codec: AAC
Profile: LC
Layout: stereo
Channels: 2 ch
Bitrate: 98 kbps
Sample rate: 48000 Hz
Default: No
Forced: No
External: No

Subtitle
Title: Dialogue (Doki) - Japanese - ASS
Language: jpn
Codec: ASS
Default: No
Forced: No
External: No

UPDATE: Spelling mistakes

@Maxr1998
Copy link
Member

Thanks, I think I understand the issue now.
Could you check if subtitle selection works if you enable "allow ssa/ass in direct play" in the client settings?

@silentTeee
Copy link
Author

Wow, you have good instincts: turning on "allow ssa/ass in direct play" got the in-player Subtitle selection to work!

@Maxr1998
Copy link
Member

Awesome, I could reproduce this issue on one of my shows as well, I'll try to fix it before we go stable with 2.5.0.

@silentTeee
Copy link
Author

Woohoo, thanks so much for being so responsive!

Also thank you for contributing your time to the mobile app: the main reason I set up Jellyfin in the first place was actually to watch my shows and listen to my music from my phone while commuting, so you have made every day of the week a little more enjoyable. I look forward to seeing what else happens with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants