Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to download over non-roaming mobile networks #1330

Closed
taitsmith opened this issue Apr 4, 2024 · 1 comment · Fixed by #1341
Closed

No option to download over non-roaming mobile networks #1330

taitsmith opened this issue Apr 4, 2024 · 1 comment · Fixed by #1341
Labels
bug Something isn't working confirmed Confirmed bug reports that shouldn't go stale

Comments

@taitsmith
Copy link
Contributor

I suppose this is tangentially related to #1326 and can be rolled into a PR for that, or one of its own.

When attempting to download some media for the first time, users are presented with a choice of allowed network types, which currently consists of 'wifi only' and 'mobile data and roaming':
ss_no_mobile

When the dialog is created here, setPositiveButton() is called twice which turns 'mobile data' to 'mobile data and roaming'. Changing one to setNeutralButton() (and swapping negative/positive for order) provides users all three options:
ss_mobile_roaming

@Maxr1998
Copy link
Member

Maxr1998 commented Apr 7, 2024

That's definitely an oversight! You are welcome to create a pull request to fix that too 👍

@Maxr1998 Maxr1998 added bug Something isn't working confirmed Confirmed bug reports that shouldn't go stale labels Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed Confirmed bug reports that shouldn't go stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants