Design for "Remove From Continue Watching"

[westonhowe98]

Here is the write up of the current design we have for implementing this feature.

1. Add an entry to the item context menu for "Remove from Continue Watching"
2. Create a new boolean flag "ExcludedFromContinueWatching"
3. The command in the context menu will set the flag to true and save it to the database
4. Modify the query that sources Continue Watching to exclude entries with this flag.
5. When a user starts playing an object set the flag to false so the item can show again in Continue Watching

This seems pretty straight forward.

We have looked into how to implement this feature and have a few concerns:

• The flag needs to be store per user similar to lastPlayedDate, playbackPosition etc.
• So we would likely need a new column in the "UserDatas" table.
• Would this require the creation of a migration script?

It seems we would need to modify the "InternalItemsQuery" object to be able to include this flag.
I assume we would also need to modify the SqliteItemReposity class to modify the generation of the query.

An alternative to modifying InteralItemsQuery would be to separately get a list of guids that have the exclude flag for the current user
and include them in the "ExcludeItemIds" property of the query. This might be more straight forward if there is a way to do a more manual sql query to get the list of guids?

An alternative to the flag design as a whole would be to instead offer the user the option to reset the watch time.
This would remove the need to make any modifications to the database or query generation.
The advantage of the flag would be to keep the users current watch position but still exclude it.

[nathangur]

This path is a bit different from my implementation. I've gone down the route of simply removing the item from Continue Watching without resetting the user's position in the piece of media.

[nathangur]

I'm currently struggling with making the connection between the server and the web client as I'm getting some api errors.

[westonhowe98]

So the main method we've proposed of using a flag wouldn't affect the users position. Resetting the users position is an alternative method of removing it from continue watching since only items with some play time will be considered

[nathangur]

I see. If you are fine with it, I'd like to help you guy's with continuing your implementation. I don't think I can get mine to work in it's current state without some major changes

[BrennanWoodbury]

Sure thing, DM'd you on element.

[neopc10]

I'd love to see this extended to "Remove from Next Up" if there's an appetite for that.

[westonhowe98]

We went ahead and added this feature as well in a separate PR.

[nathangur]

@cvium Why did you reopen this discussion? Was there something you'd like to add?

[thornbill]

As I commented on one of the open PRs related to this:

Sorry if the process hasn't been clear. The Jellyfin team needs to be involved in the discussion to make sure the implementation aligns with best practices, etc. That is the main reason a discussion is needed first for changes of a larger scope or fundamental nature.

[nathangur]

Ah I see!

[JPVenson]

What is the benefit of this over just marking the item as played via the check icon?

[thornbill]

Now I'm second guessing if just resetting the watch status is "good enough". I tested some streaming services and they have the ability to remove items without losing the watch status. 🤷‍♂️

[JPVenson]

Well i would prefer not to build that much logic into the current system but maybe rethink it. The reset of the watch status would be easy to implement, get the job done and does not introduce more code then absolutely necessary.

[nathangur]

Another reason why we added a DB field is for having a timer to automatically remove items from continue watching after a certain period of time without changing the watch status. This is pretty highly requested, and people like to keep things clean without wiping where they left off. And, when you click the watched button, it adds it to next up, cluttering that when you are really just trying to clean up your library.

Little things like this that are just assumed to be good enough for the user just adds a little extra edge to the Jellyfin experience. At least in my opinion :)

[nathangur]

Back again to talk about this implementation. I've had a bunch of items that I want to exclude from continue watching or next up and have had to mark the whole thing as watched. It's genuinely quite annoying to deal with.

[JPVenson]

Well the server team discussed the current PR and the general idea. We like the idea and are overall very dissatisfied how the current next-up system works. We decided that any change to the current system just adds code to a complex system that needs a complete overhaul anyway. The idea is worthwhile but we dont want to change the existing code for now.

[spooksbit]

An alternative to the flag design as a whole would be to instead offer the user the option to reset the watch time.

This appears to be achievable right now by making a POST request to /Users/{userId}/Items/{itemId}/UserData with {"PlaybackPositionTicks": 0}. From my own testing, I am finding that items are being removed after making the request, but other fields appear to be retained (ie last played, play count, etc).

Would this be an acceptable solution?

[spooksbit]

My apologies if this has already been discussed, but what is the value proposition in retaining playback position after removing items from this list? This action seems to carry an explicit intent to forget where one has stopped playback, rather than an intent to retain playback position.

Comments from the feature request do not indicate this as a requirement either. To the contrary. resetting the playback position has been noted as "acceptable" behavior by some users and even desired by others. Maybe I'm the minority here, but it feels more like an anti-feature to retain playback position.

Is there maybe a different feature that is being implemented by requiring this behavior?

[nathangur]

My apologies if this has already been discussed, but what is the value proposition in retaining playback position after removing items from this list? This action seems to carry an explicit intent to forget where one has stopped playback, rather than an intent to retain playback position.

Comments from the feature request do not indicate this as a requirement either. To the contrary. resetting the playback position has been noted as "acceptable" behavior by some users and even desired by others. Maybe I'm the minority here, but it feels more like an anti-feature to retain playback position.

Actually I think the opposite is true. Currently you can mark an item as watched and that resets the playback position and marks it as watched. Then you can just uncheck it again to have it completely reset. However, the feature request wanted to retain the watch position but remove the item from continue watching or next up. This is especially useful for admins who play media for testing and have a lot of items on their front page, and if the PR's relating to this discussion had been accepted then a timer setting would have been proposed to remove items from either category after a period of time, similar to a feature Plex has.

Is there maybe a different feature that is being implemented by requiring this behavior?

The only thing that was planned was the timer. I personally would have used this (and am currently using it on my dev server) to keep things clean and uncluttered. Which is essentially what this feature aimed to accomplish, cleaning up the list of 100+ items from my continue watching category but not erasing the playback position. Is this a necessary feature? By all means no, but I am a firm believer that the little things that may seem insignificant or not useful actually add to the user experience. Even if a user never uses it, having the ability to do something solidifies the user experience.

And thus concludes my long winded, unneeded essay :)

[spooksbit]

However, the feature request wanted to retain the watch position but remove the item from continue watching or next up

Here are some comment excerpts from the feature request which seem to contradict this sentiment:

It would definitely be fine for the watched progress to be reset when it's removed.

If it can help or give ideas, [X] offers an option on items that have been partly watched to "reset resume time". I use it fairly often and it is a nice way to avoid the problem around changing the item's watched status

The "Continue Watching" just gets anoying and in the way if you cant remove stuff. I also like [X]'s option to reset resume time.

At the very least, it sounds like an option to reset playback position could be submitted as a feature request in the future.

In the case of testing media, wouldn't the retained playback position be the time that was chosen for testing purposes? If it is (and please correct me if I'm wrong), I would think it's desirable to discard that position instead of retaining it. If I was testing a movie and skipped to the middle to validate subtitles worked and removed it from the list, I would not want to be returned to that spot when I go to actually watch it later. From the comments, it sounds like usually the first few minutes of an item is used for testing which is not significantly different from the playback position of 0. If anything, I could see the option of resetting playback to 0 being presented as an enhancement by users to better support that specific use case since otherwise each item would play from some arbitrary point near the start and it would make sense to just reset the position.

Maybe I am the minority here, but retaining playback position sounds more like an annoying side effect and I feel would take away from user experience rather than add to it. It also seems that the proposed changes are at an impasse for legitimate concerns, but it also seems like those concerns are based on an implementation that is unnecessarily too strict. Instead, I think resetting the playback position relaxes the implementation in a way that not only eliminates the maintenance concerns but is also more desirable by users. Win-Win.

[nathangur]

I think you misunderstood what this implementation is. This is for an extra button in the action menu for an item. It's not replacing marking an item as watched.

[spooksbit]

I would not expect it to replace marking an item as watched? Clearing the position does not mark an item as watched so that button would continue to exist.

See: spooksbit/jellyfin-web@9cc592d