You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should add a check to the CI process that counts the number warnings in the build and fails if it is above some threshold 'N'. The threshold should be in a file committed to the repository and reduced on each PR so that over time we reduce the number of warnings to zero.
Also proposed is that this CI check would function to replace a lot of the manual reviews of styling issues in PRs. Basically, as long as the number of warnings goes down its fine to ignore other minor styling issues in the code review.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
from jellyfin/jellyfin#2954
We should add a check to the CI process that counts the number warnings in the build and fails if it is above some threshold 'N'. The threshold should be in a file committed to the repository and reduced on each PR so that over time we reduce the number of warnings to zero.
Also proposed is that this CI check would function to replace a lot of the manual reviews of styling issues in PRs. Basically, as long as the number of warnings goes down its fine to ignore other minor styling issues in the code review.
Beta Was this translation helpful? Give feedback.
All reactions