Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jellyfin get the absolute order from the tvdb API #101

Closed
Arlind-dev opened this issue Oct 20, 2023 · 18 comments · Fixed by #143
Closed

Make Jellyfin get the absolute order from the tvdb API #101

Arlind-dev opened this issue Oct 20, 2023 · 18 comments · Fixed by #143

Comments

@Arlind-dev
Copy link

I have tried doing that by using the Season ID of the absolute order but with no success, is there a limitation I am not familiar with?
Tried with https://thetvdb.com/series/one-piece/

@daynyxx
Copy link

daynyxx commented Nov 2, 2023

This would be an awesome feature. For example, the monogotari series being able to choose between aired order vs dvd vs absolute would be helpful.

@ttkjk
Copy link

ttkjk commented Jan 27, 2024

Yes,I think this feature it's necessary.

This would be an awesome feature. For example, the monogotari series being able to choose between aired order vs dvd vs absolute would be helpful.

@lapidary-master
Copy link

This isn't any limitation, the easiest way to set the display order is Profile -> Metadata Manager -> Collection Name -> One Piece then you can change the Display order from Aired to;

  • Original Air Date
  • Absolute
  • DVD
  • Digital
  • Story Arc
  • Production
  • TV

To be honest, I have never personally used anything outside of Aired but I think that's just a me thing 😅 Just kinda bend my media to the Aired order kinda vibe.

@Arlind-dev
Copy link
Author

This isn't any limitation, the easiest way to set the display order is Profile -> Metadata Manager -> Collection Name -> One Piece then you can change the Display order from Aired to;

  • Original Air Date
  • Absolute
  • DVD
  • Digital
  • Story Arc
  • Production
  • TV

To be honest, I have never personally used anything outside of Aired but I think that's just a me thing 😅 Just kinda bend my media to the Aired order kinda vibe.

Hi, thanks for the reply, this is only for TMDB.

@ChildishhAlbino
Copy link

Hi - adding to this issue, I would also like the ability to fetch the DVD order. I am loading the blu ray version of Avatar - The Last Airbender to my Jellyfin server and noticing two things:

  1. This plugin is NOT respecting the collections choice of series ordering, despite the information existing on TVDB
  2. I can't use TMDB as a fallback as they do not have the correct ordering on their service.

@ChildishhAlbino
Copy link

@scampower3 just bringing this to your attention as I've seen your commits change stuff I believe is related to this and just wanted to know if this is a recent occurrence.

I know from my anecdotal experience this was working in V10 of this plugin and seems to have broken in V11.

If you want me to raise a separate issue for this as this one has gotten quite old/stale - I can.

@scampower3
Copy link
Member

scampower3 commented May 21, 2024

Hello, this is a known issue. No need to create a new issue for this.

Bug was introduced here:fc7b8fe

Should be fixed with #143

@ChildishhAlbino
Copy link

@scampower3 thanks for clarifying - so clearing the plugin cache would be a temporary workaround for this?

@scampower3
Copy link
Member

scampower3 commented May 21, 2024

The clear plugin cache + identify workaround should work. But, it might reorder the episodes.

Alternatively, you can test this https://github.com/scampower3/jellyfin-plugin-tvdb/releases/tag/test but this is 2 commits off from https://github.com/scampower3/jellyfin-plugin-tvdb/tree/restrict-some-data but is tested to be working with a user in the troubleshooting channel.

@ChildishhAlbino
Copy link

Yeah I'm hoping it will re-order the episodes - or in my case, correctly order them.

I'll check both of those out thanks @scampower3

@scampower3
Copy link
Member

@ChildishhAlbino I added an updated release here: https://github.com/scampower3/jellyfin-plugin-tvdb/releases/tag/test2

@ChildishhAlbino
Copy link

ChildishhAlbino commented May 21, 2024

hey @scampower3 I might still raise a separate issue because whilst that fix did actually grab the correct episode title and details for the variant episodes - it is marking them as specials instead of episodes in the season.

It is also incorrect labelling the episodes after the specials with their aired order numbering/titles the succeed the places where the specials are located.

A few examples and I'll let you tell me if this is expected behaviour or not (i don't presume so)

Season 2 episode 12 (dvd order)

TVDB
image
JF
image

Season 2 Episode 13

TVDB
image
JF
image

EDIT: FWIW It looks to me that the plugin is just grabbing the incorrect episode number/season number (in the case of the the "specials") and that's shifting the metadata to the next episode in the correct ordering - so potentially there is a bug with the logic that grabs the episode numbers. I have manually fixed this for now but this doesn't seem like expected behaviour to me.

@scampower3
Copy link
Member

scampower3 commented May 21, 2024

The plugin depends on the season and episode numbers that Jellyfin provides. It shouldn't modify the season and episode numbering.

Can you send me the steps that caused this issue to occur with your folder and file naming structure?

@ChildishhAlbino
Copy link

ChildishhAlbino commented May 21, 2024

Ok - maybe it is an issue with Jellyfin itself and not the plugin - although the files are labelled with the correct episode number in their filename.

  1. Install the test version of the plugin manually using
  2. Purge the plugin cache and set the show order to DVD order
  3. Identify the show again as "Avatar - The Last Airbender" from TVDB
  4. Check the episode titles in Season 2 (the first season where a difference from Aired Order and DVD order occurs)

Episode 12 and Episode 18 are the two episodes that turn into "specials" but it does correctly source the correct tvdbID value for each episode. (so you might be right this isn't a plugin issue)

image

@scampower3
Copy link
Member

scampower3 commented May 21, 2024

When you set the show to the display order, Jellyfin will automatically run the full refresh, no need to do the identify again.

Episode 12 and Episode 18 are the two episodes that turn into "specials" but it does correctly source the correct tvdbID value for each episode. (so you might be right this isn't a plugin issue)

Maybe. Can you check whether this occurs with a different show? Maybe with only tvdb plugin enabled to isolate any other variables.

@ChildishhAlbino
Copy link

ChildishhAlbino commented May 21, 2024

Can do - I'll report back.

EDIT: might take me a bit - i'm getting a NotSupported error with the plugin now. I'll debug and report back.

@ChildishhAlbino
Copy link

Ok @scampower3 - even disabling all the other metadata plugins - I can't get this to work properly. I tested the plugin using "Dragon Ball Z Kai" which has a similar difference between Aired Order and DVD Order (best I can do) and it seemed to work fine.

It is odd to me because the plugin is finding the correct TVDB id for each of the episodes but it using the season/episode number from the "Aired Order" and not from the "DVD Order" and that causes it to search for the wrong metadata in the DVD order.

Is there a better forum to discuss this issue in real time? I don't understand where JF is getting the metadata from if not from this plugin.

@scampower3
Copy link
Member

scampower3 commented May 21, 2024

Can pm on discord

From discord covo: Resolved after restarting the server after the new dll is moved into the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants