From b7bcb9c60493f1a4dbf087c5e52702bfcc285fd2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Fern=C3=A1ndez?= Date: Wed, 15 Feb 2023 23:30:50 -0800 Subject: [PATCH] fix: failing github actions Co-authored-by: aweebs <8809837+aweebs@users.noreply.github.com> Due to a regression in npm 9.3.0 (upgraded by Node.JS 18 LTS at 18.14.0, see https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-02-02-version-18140-hydrogen-lts-bethgriggs-prepared-by-juanarbol), the `npm get config` command stopped working in workspaces. This made our actions using actions/setup-node to fail. Issues were opened in the relevant repositories since january and february (check https://github.com/npm/cli/issues/6099 and https://github.com/actions/setup-node/issues/712) but it looks like getting this fixed upstream it's going to take a long time. We have been waiting for a really long time for other fixes in npm, so I don't expect this situation will be solved really soon We need a working CI before the Vue 3 merge, so applying this commit will solve the issue in the meantime. In the future, it might be interesting to revert this commit. Also format the GitHub Actions workflows using the official VSCode GitHub extension --- .github/workflows/automation.yml | 6 +++--- .github/workflows/codeQL.yml | 2 +- .github/workflows/code_quality.yml | 3 --- .github/workflows/job_messages.yml | 2 +- .github/workflows/release.yml | 11 +++++------ .github/workflows/unstable.yml | 13 ++++++------- 6 files changed, 16 insertions(+), 21 deletions(-) diff --git a/.github/workflows/automation.yml b/.github/workflows/automation.yml index bccc0733304..e43b1e0631c 100644 --- a/.github/workflows/automation.yml +++ b/.github/workflows/automation.yml @@ -9,7 +9,7 @@ on: branches: - master paths-ignore: - - '**/*.md' + - "**/*.md" pull_request_target: jobs: @@ -63,10 +63,10 @@ jobs: if: ${{ github.event_name == 'pull_request_target' }} continue-on-error: true with: - repo-token: '${{ secrets.JF_BOT_TOKEN }}' + repo-token: "${{ secrets.JF_BOT_TOKEN }}" - name: Check all PRs for merge conflicts ⛔ uses: eps1lon/actions-label-merge-conflict@v2.1.0 with: - dirtyLabel: 'merge conflict' + dirtyLabel: "merge conflict" repoToken: ${{ secrets.JF_BOT_TOKEN }} diff --git a/.github/workflows/codeQL.yml b/.github/workflows/codeQL.yml index 146ec020570..c1bb26521ab 100644 --- a/.github/workflows/codeQL.yml +++ b/.github/workflows/codeQL.yml @@ -10,7 +10,7 @@ on: - master pull_request: paths-ignore: - - '**/*.md' + - "**/*.md" workflow_call: jobs: diff --git a/.github/workflows/code_quality.yml b/.github/workflows/code_quality.yml index 6028749ff27..faac7af3b11 100644 --- a/.github/workflows/code_quality.yml +++ b/.github/workflows/code_quality.yml @@ -35,7 +35,6 @@ jobs: uses: actions/setup-node@v3.5.1 with: node-version: 18 - cache: "npm" check-latest: true - name: Install dependencies 📦 @@ -56,7 +55,6 @@ jobs: uses: actions/setup-node@v3.5.1 with: node-version: 18 - cache: "npm" check-latest: true - name: Install dependencies 📦 @@ -139,7 +137,6 @@ jobs: uses: actions/setup-node@v3.5.1 with: node-version: 18 - cache: "npm" check-latest: true - name: Install dependencies 📦 diff --git a/.github/workflows/job_messages.yml b/.github/workflows/job_messages.yml index e4a8fda9f14..209f7817a8e 100644 --- a/.github/workflows/job_messages.yml +++ b/.github/workflows/job_messages.yml @@ -27,7 +27,7 @@ on: value: ${{ jobs.msg.outputs.msg }} marker: description: Hidden marker to detect PR comments composed by the bot - value: 'CFPages-deployment' + value: "CFPages-deployment" jobs: msg: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index caa022b9eec..75ff498a4fc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -72,9 +72,9 @@ jobs: fail-fast: false matrix: platform: - - 'macos-latest' - - 'ubuntu-latest' - - 'windows-latest' + - "macos-latest" + - "ubuntu-latest" + - "windows-latest" runs-on: ${{ matrix.platform }} steps: @@ -85,7 +85,6 @@ jobs: uses: actions/setup-node@v3.5.1 with: node-version: 18 - cache: 'npm' check-latest: true - name: Install dependencies 📦 @@ -98,10 +97,10 @@ jobs: sudo apt-get install -y webkit2gtk-4.0 - name: Generate Tauri icons 🖌️ - run: 'npm run tauri:icon -w tauri' + run: "npm run tauri:icon -w tauri" - name: Build Tauri 🛠️ - run: 'npm run tauri:build -w tauri' + run: "npm run tauri:build -w tauri" - name: Upload artifact (Linux) ⬆️🐧 uses: actions/upload-artifact@v3.1.1 diff --git a/.github/workflows/unstable.yml b/.github/workflows/unstable.yml index 48839e14028..18e8a76f570 100644 --- a/.github/workflows/unstable.yml +++ b/.github/workflows/unstable.yml @@ -9,7 +9,7 @@ on: branches: - master paths-ignore: - - '**/*.md' + - "**/*.md" jobs: docker: @@ -78,9 +78,9 @@ jobs: fail-fast: false matrix: platform: - - 'macos-latest' - - 'ubuntu-latest' - - 'windows-latest' + - "macos-latest" + - "ubuntu-latest" + - "windows-latest" runs-on: ${{ matrix.platform }} steps: @@ -91,7 +91,6 @@ jobs: uses: actions/setup-node@v3.5.1 with: node-version: 18 - cache: 'npm' check-latest: true - name: Install dependencies 📦 @@ -104,10 +103,10 @@ jobs: sudo apt-get install -y webkit2gtk-4.0 - name: Generate Tauri icons 🖌️ - run: 'npm run tauri:icon -w tauri' + run: "npm run tauri:icon -w tauri" - name: Build Tauri 🛠️ - run: 'npm run tauri:build -w tauri' + run: "npm run tauri:build -w tauri" - name: Upload artifact (Linux) ⬆️🐧 uses: actions/upload-artifact@v3.1.1