Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable modern bundle #1516

Closed
ThibaultNocchi opened this issue Oct 8, 2021 · 1 comment · Fixed by #1812
Closed

Enable modern bundle #1516

ThibaultNocchi opened this issue Oct 8, 2021 · 1 comment · Fixed by #1812
Labels
enhancement New feature or request

Comments

@ThibaultNocchi
Copy link
Member

ThibaultNocchi commented Oct 8, 2021 •
edited
Loading

Description of the bug

After #1515, modern bundle has been disabled to make it work with the transpiled jf-client-axios dependency.

We should investigate that further to make it work. Either fix the dependency or our build methods.
@ThibaultNocchi ThibaultNocchi added the enhancement New feature or request label Oct 8, 2021
@ferferga
Copy link
Member

ferferga commented Dec 5, 2021

Seems Nuxt 3 will be modern by default: nuxt/nuxt#4552 (comment)

Which makes sense, since Vue 3 won't support old browsers anyway.
We can close this as soon as we move to Nuxt 3 (or we investigate if Nuxt bridge has that covered as well)

@ferferga ferferga mentioned this issue Dec 5, 2021
Merged
@ferferga ferferga linked a pull request Dec 15, 2022 that will close this issue
chore: upgrade to Vue 3 #1812
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to Vue 3 jellyfin/jellyfin-vue
2 participants
@ThibaultNocchi @ferferga