Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server without specifying a protocol #1688

Closed
doc-code-hub opened this issue Jan 11, 2022 · 0 comments · Fixed by #1812
Closed

Add server without specifying a protocol #1688

doc-code-hub opened this issue Jan 11, 2022 · 0 comments · Fixed by #1812
Labels
confirmed This bug was reproduced successfully by multiple people enhancement New feature or request good first issue Good for newcomers ui/ux Pull requests or issues that deal with UX or UI design

Comments

@doc-code-hub
Copy link
Contributor

doc-code-hub commented Jan 11, 2022

Not quite a bug, more a mini-feature request:

As allowed by the original website, I think it would be nice and convenient, to allow the insertion of an IP address (without protocol) with any specified port.

Taking it a step further, it could still improve over the original site (which allows any text in the field, and tries the call) by updating the current validation regex, with one that actually covers only the interesting cases (and maybe adding a default http protocol beahind the scenes if needed).

I don't have enough RegEx skills to propose a valid and consistent change.

Does anyone have an interest in dealing with it?

Steps to reproduce

I.E. 192.168.1.5 does not allow adding

Expected behavior

I.E. 192.168.1.5 as input should work fine!

Screenshots

From the original website

image

@doc-code-hub doc-code-hub added the bug Something isn't working label Jan 11, 2022
@ThibaultNocchi ThibaultNocchi added confirmed This bug was reproduced successfully by multiple people enhancement New feature or request good first issue Good for newcomers ui/ux Pull requests or issues that deal with UX or UI design and removed bug Something isn't working labels Jan 11, 2022
@flwst flwst mentioned this issue Jan 15, 2022
@ferferga ferferga linked a pull request Dec 15, 2022 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This bug was reproduced successfully by multiple people enhancement New feature or request good first issue Good for newcomers ui/ux Pull requests or issues that deal with UX or UI design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants