Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add build variant to set router base #529

Closed
crobibero opened this issue Jan 10, 2021 · 2 comments · Fixed by #1812
Closed

[Enhancement] Add build variant to set router base #529

crobibero opened this issue Jan 10, 2021 · 2 comments · Fixed by #1812
Labels
confirmed This bug was reproduced successfully by multiple people enhancement New feature or request

Comments

@crobibero
Copy link
Member

crobibero commented Jan 10, 2021

  router: {
	[...]
    base: '/web/'
  },

This would allow jellyfin-server to host the generated static files in place of jellyfin-web

Edit: This also doesn't work if jellyfin is hosted under a baseurl
image

Edit many months later:

Setting the router.base field to ./ allows the ui to load, and only vue fonts and images fail to load

@crobibero crobibero changed the title Add build variant to set router base [Enhancement] Add build variant to set router base Jan 10, 2021
@ThibaultNocchi ThibaultNocchi added the enhancement New feature or request label Apr 10, 2021
@stale
Copy link

stale bot commented Jun 9, 2021

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale This issue or PR hasn't been updated in at least 60 days label Jun 9, 2021
@heyhippari heyhippari removed the stale This issue or PR hasn't been updated in at least 60 days label Jun 13, 2021
@stale
Copy link

stale bot commented Aug 21, 2021

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale This issue or PR hasn't been updated in at least 60 days label Aug 21, 2021
@ThibaultNocchi ThibaultNocchi added the confirmed This bug was reproduced successfully by multiple people label Aug 21, 2021
@stale stale bot removed the stale This issue or PR hasn't been updated in at least 60 days label Aug 21, 2021
@ferferga ferferga linked a pull request Dec 15, 2022 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This bug was reproduced successfully by multiple people enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants