Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change subtitle title to actual title instead of language #157

Closed
Evoley opened this issue Feb 25, 2019 · 2 comments
Closed

Change subtitle title to actual title instead of language #157

Evoley opened this issue Feb 25, 2019 · 2 comments
Labels
enhancement Improve existing functionality or small fixes

Comments

@Evoley
Copy link

Evoley commented Feb 25, 2019

Describe the solution you'd like
Instead of subtitles saying "eng default" it would be nice if it said "Signs and Songs" or any other title indicated in MediaInfo

Describe alternatives you've considered
Subtitle
Title Eng Default (would be Signs & Songs)
Language eng (would stay the same)
Codec ASS (would stay the same)
Default Yes (would stay the same)
Forced No (would stay the same)
External No (would stay the same)

Additional context
This primarily concerns anime with signs and songs and custom subtitle titles (Dialogue [Manko]). The downside that I can think of to this is that subtitles without titles would probably be messed up.

Example taken from MediaInfo v18.12

Text #1
ID : 4
Format : ASS
Codec ID : S_TEXT/ASS
Codec ID/Info : Advanced Sub Station Alpha
Duration : 23 min 24 s
Bit rate : 55 b/s
Count of elements : 116
Compression mode : Lossless
Stream size : 9.50 KiB (0%)
Title : Signs & Songs
Language : English
Default : Yes
Forced : No

Text #2
ID : 5
Format : ASS
Codec ID : S_TEXT/ASS
Codec ID/Info : Advanced Sub Station Alpha
Duration : 24 min 13 s
Bit rate : 179 b/s
Count of elements : 555
Compression mode : Lossless
Stream size : 31.9 KiB (0%)
Title : Dialogue [Manko]
Language : English
Default : No
Forced : No

@Evoley Evoley added the enhancement Improve existing functionality or small fixes label Feb 25, 2019
@JustAMan
Copy link
Contributor

subtitles without titles would probably be messed up

Well, if they lack titles we should fallback to current behaviour. Plus adding a language code like Subs Title [lang] would be good IMHO.

@jellyfin-bot
Copy link
Collaborator

We are moving all feature and enhancement requests to our new Fider platform here. This new platform lets people vote on and better manage such requests.
This request now lives here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Development

No branches or pull requests

3 participants