Merge pull request #1438 from dduportal/fix/rsyncd/svc-lb-whitelist

fix(rsyncd) service: do not specify an empty 'loadBalancerSourceRanges' when using a LB with no whiteliste specified
jenkins-infra · Nov 25, 2024 · a446219 · a446219
2 parents f867abd + 49fdd17
commit a446219
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/charts/rsyncd/Chart.yaml b/charts/rsyncd/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: rsyncd helm chart for Kubernetes
 name: rsyncd
-version: 2.0.1
+version: 2.0.2
 maintainers:
 - email: jenkins-infra-team@googlegroups.com
   name: jenkins-infra-team
diff --git a/charts/rsyncd/templates/service.yaml b/charts/rsyncd/templates/service.yaml
@@ -11,12 +11,14 @@ metadata:
 spec:
   type: {{ .Values.service.type }}
   {{- if eq .Values.service.type "LoadBalancer" }}
-  {{- with .Values.service.LoadBalancerIP }}
+    {{- with .Values.service.LoadBalancerIP }}
   loadBalancerIP: {{ . }}
-  {{- end }}
+    {{- end }}
+    {{- with .Values.service.whitelisted_sources }}
   loadBalancerSourceRanges:
-    {{- range .Values.service.whitelisted_sources }}
+      {{- range . }}
     - {{ . | quote }}
+      {{- end }}
     {{- end }}
   {{- end }}
   ports: