feat(geoipupdater): remove the mount for the pvc as we use azcopy #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
Nov 28, 2024
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
smerle33
force-pushed
the
geoip-nomount
branch
from
e6df0e2 to
a88ab32
Compare
dduportal
reviewed
Dec 2, 2024
dduportal
reviewed
Dec 2, 2024
dduportal
reviewed
Dec 2, 2024
dduportal
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/helpdesk#4278
⚠️ BREAKING CHANGE
providing a new chart version to avoid the mount for the pvc but provide the informations for the fileshare target for azcopy.
it remove the pvc mounting and rely only on the azcopy.
it change the definition of the image used to match the ones we are using
add the dry-run option to avoid geoip ratelimit
depends on jenkins-infra/docker-geoipupdate#11 and jenkins-infra/docker-geoipupdate#13
split the kubernetes objects within 2 files (one for rbac, and one for the cronjob) with corresponding unit test.
Change the docker image to use to our own image see https://github.com/jenkins-infra/docker-geoipupdate and update the corresponding updatecli manifest to track it.
Change the DEFAULT dry-run value to true.
The resources are not set but correct minimum values are provided within a comment.