fix(account-app) correct default values for 'resources' to avoid YAML parsing error #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parsing error Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
|
|
Self-merging as this PR fixes the updatecli build |
hervelemeur
reviewed
Sep 25, 2023
| @@ -29,8 +29,8 @@ ingress: | |||
| # - secretName: accounts-tls | |||
| # hosts: | |||
| # - accounts.jenkins.io | |||
| resources: # We usually recommend not to specify default resources and to leave this as a conscious | |||
| # choice for the user. This also increases chances charts run on environments with little | |||
| # We usually recommend not to specify default resources and to leave this as a conscious: null # choice for the user. This also increases chances charts run on environments with little | |||
There was a problem hiding this comment.
null or empty object? The comment seems to imply one should change the defaut {} value to null
Also, should this be splited to two lines?
There was a problem hiding this comment.
Good catch. The fix with with helm control flow element does not care as the resulting template pipeline is false wether the value is null, empty or undefined.
PR to update the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @olblak for catching the root issue ❤️
This PR fixes an issue when using the default value for
resourceswhich should be{}to ensure all YAML parser consider it as null.Please note that I have a personal preference for commenting out the empty or undefined values on helm charts, but this fix will do.