Do not depend on nodeJS version in example output #7695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent documentation feedback noted that the incorrect version number string is included in the sample output. Rather than adjust the example output, let's use example output that is unlikely to change between NodeJS releases. This example uses `process.platform` and `process.env.CI`. Those are not likely to change from one version of nodeJS to the next. https://docs.google.com/spreadsheets/d/1nA8xVOkyKmZ8oTYSLdwjborT0w-BpBNNZT0nxR9deZ8/edit?usp=sharing is the feedback sheet that included the note that the NodeJS version number is incorrect in the example output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not depend on nodeJS version in example output
A recent documentation feedback noted that the incorrect version number string is included in the sample output. Rather than adjust the example output, let's use example output that is unlikely to change between NodeJS releases. This example uses
process.platformandprocess.env.CI. Those are not likely to change from one version of nodeJS to the next.The feedback sheet includes the note that the NodeJS version number is incorrect in the example output.