Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe to check whether the libraries are deprecated or not in the plugin. #470

Open
AayushSaini101 opened this issue Feb 21, 2024 · 3 comments
Labels
enhancement New feature or request probe Related to probe implementation

Comments

@AayushSaini101
Copy link
Contributor

Description

  • Upgrade JUnit 3 tests to JUnit 4
  • Replace joda-time with Java 11 time

These are the need of changes required as per plugin modernisation

@AayushSaini101 AayushSaini101 added enhancement New feature or request probe Related to probe implementation labels Feb 21, 2024
@krisstern
Copy link
Member

Sounds like a cool idea to have as a probe, but to be up-to-date I would say maybe JUnit 5 instead of 4 even? Maybe a good idea to do some research on what this probe ideally should cover, as I suspect there is a lot more.

@alecharp
Copy link
Collaborator

The probes are non judgemental. The probes (one for each) should be to get the versions of known libraries.
Then, we can have a scoring (PluginMaintenance?) which would evaluate those results and determine if the plugin is using up to date or not libraries.

However, there is no recommendation to use JUnit 5 over JUnit 4 in the community.
Also, some plugins are using libraries which are using Joda Time. There is nothing wrong in using Joda time rather than JDK classes. We even just added the Joda Time API plugin (https://github.com/jenkinsci/joda-time-api-plugin). I'm willing to agree and say JDK >>> Joda Time but there is no clear statement that we should move away from Joda Time.

@AayushSaini101
Copy link
Contributor Author

The probes are non judgemental. The probes (one for each) should be to get the versions of known libraries. Then, we can have a scoring (PluginMaintenance?) which would evaluate those results and determine if the plugin is using up to date or not libraries.

However, there is no recommendation to use JUnit 5 over JUnit 4 in the community. Also, some plugins are using libraries which are using Joda Time. There is nothing wrong in using Joda time rather than JDK classes. We even just added the Joda Time API plugin (https://github.com/jenkinsci/joda-time-api-plugin). I'm willing to agree and say JDK >>> Joda Time but there is no clear statement that we should move away from Joda Time.

I agree with @alecharp It is good to have a probe for each to get the version of known libraries. Regarding the migration of the version from Upgrade JUnit 3 tests to JUnit 4 and Replace joda-time with Java 11 time it is mentioned in the Contribute to Open Source guidelines by Jenkins

@alecharp alecharp added the gsoc Do not take / work on GSoC tickets outside of GSoC context. label Mar 4, 2024
@alecharp alecharp changed the title Probe to check whether the libraries are depracted or not in the plugin. Probe to check whether the libraries are deprecated or not in the plugin. Mar 7, 2024
@alecharp alecharp removed the gsoc Do not take / work on GSoC tickets outside of GSoC context. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request probe Related to probe implementation
Projects
None yet
Development

No branches or pull requests

3 participants