Jenkinsfile Modification: Unexpected End-of-Comment Behavior

[gounthar]

When running the AddOrModernizeJenkinsFile recipe, the generated comment does not create a new line. As a result, the subsequent buildPlugin statement is appended to the comment, rather than starting on a new line.

You can see this issue in this pull request.

Reproduction Steps

1. Run the AddOrModernizeJenkinsFile recipe on a plugin with an outdated Jenkinsfile.

Expected Behavior

The recipe should add a new line and carriage return after the comment.

Actual Behavior

The comment does not create a new line, and the buildPlugin statement is appended to it.

[jonesbusy]

Is it and issue with plugin modernizer or rewrite-jenkins ? From wat I remember we don't modify and Jenkinsfile here but just use a recipe from rewrite-jenkins

[jonesbusy]

Or even with rewite-groovy that fail to parse a correct LST ?

[gounthar]

Yes, that's also what I think, but I prefer to have it logged here before forgetting about it.

[gounthar]

What is strange is that the newline is in the OpenRewrite recipe.