Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --plugin-path on PluginOptions #503

Open
jonesbusy opened this issue Dec 23, 2024 · 1 comment
Open

Support --plugin-path on PluginOptions #503

jonesbusy opened this issue Dec 23, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jonesbusy
Copy link
Collaborator

jonesbusy commented Dec 23, 2024

What feature do you want to see added?

Not sure if there is a 100% use case for this but I would be great to have an option --plugin-path on PluginOptions in addition of --plugins and --plugin-file to use an already checkout plugin (or a plugin not distributed to a update center). For example private and just installed via the .hpi

We need to see if we use this option to not perform any remote check (update center, health, remote branch PR) etc...

It would be also useful for manual testing

Instead of

 mvn org.openrewrite.maven:rewrite-maven-plugin:dryRun -Drewrite.recipeArtifactCoordinates=io.jenkins.plugin-modernizer:plugin-modernizer-core:999999-SNAPSHOT -Drewrite.activeRecipes=io.jenkins.tools.pluginmodernizer.core.recipes.IsUsingBom

We could have

plugin-modernizer (dry-run|run) --plugin-path . --recipe IsUsingBom

Upstream changes

No response

Are you interested in contributing this feature?

No response

@jonesbusy jonesbusy added the good first issue Good for newcomers label Dec 23, 2024
@jonesbusy
Copy link
Collaborator Author

Easy to implement, but will cover few layer of plugin modernizer. It's not only adding naively the CLI option but also integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant