Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvements #36

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Code Improvements #36

merged 2 commits into from
Aug 27, 2019

Conversation

darxriggs
Copy link
Contributor

This pull request contains multiple commits, each covering a different aspect and dedicated commit message. It's therefore also a good idea to have a look at each commit individually.

Copy link
Member

@ikedam ikedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes look good as they resolve problems.

  • Using latest URIs (Old URIs will outdate)
  • Removing unused imports (they should cause warnings).

But other changes look unnecessary as original codes don’t cause problems and don’t considered wrong. I prefer preserving original codes as far as it doesn’t cause problems.
I don’t know much about latest JDKs and let me know if those original codes cause errors or warnings.

@darxriggs
Copy link
Contributor Author

Most of the changes (102059e, e0ecb9d, bdc6d9b, 17c3074, 1009d30, e4206b5) are based on findings from IntelliJ IDEA. The rest (311de6b, 5645cee) are additional suggestions from myself.

For me all of them improve the code in some way. Reducing warnings, using more up-to-date Java syntax/features, more consistency, ...

Can you name the commits you are willing to merge? Then I'll remove the other ones.

@ikedam
Copy link
Member

ikedam commented Aug 25, 2019

I don’t use IntelliJ and I’m not sure where those warnings come from (javac, findbugs, or other lint tools).
Authorized-project originally developed with java6 and there are many possible improvements with the latest java. I don’t introduce those fixes 1) to preserve original codes ( and minimize changes) , 2) I won’t do that every time the java.level changed as far as they are harmless (and this “harmless” is where we have to consider here).

Following commits are acceptable to me without any considerations:

@darxriggs
Copy link
Contributor Author

The pull request now only contains the two commits we agreed on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants