Use Xstream2#addCriticalField directly instead of via reflection #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleg-nenashev I have heard this recommendation multiple times and followed it when working on other plugins. But the more I think about it the more uncertain I am about its intent. Shouldn't a user be free to decide which version to install as long as it meets the minimum requirements? May I therefore ask you to elaborate a bit more on the background? |
ikedam
requested changes
Sep 8, 2019
Since Jenkins 2.85 (https://jenkins.io/changelog/#v2.85) this method is available for plugins. With 2.89.4. using the next LTS version with the highest patch level.
darxriggs
force-pushed
the
replace-xstream2-reflection
branch
from
e03881d to
2bce905
Compare
|
I updated the required Jenkins version. |
ikedam
approved these changes
Sep 9, 2019
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Jenkins 2.85 (https://jenkins.io/changelog/#v2.85) this method is available for plugins.