add missing synchronization context needed for rule's matchedTimes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 98.46% 98.48% +0.01%
==========================================
Files 23 23
Lines 196 198 +2
Branches 18 18
==========================================
+ Hits 193 195 +2
Misses 1 1
Partials 2 2
Continue to review full report at Codecov.
|
| @@ -40,33 +40,34 @@ public BuildHistoryManager(List<Rule> rules) { | |||
| */ | |||
| @Override | |||
| public void perform(Job<?, ?> job) throws IOException, InterruptedException { | |||
| synchronized (this) { | |||
There was a problem hiding this comment.
first, this can go to method signature as you synchronize whole method
second - the problem happens when plugin is executed twice at the same time?
There was a problem hiding this comment.
second - yes this happend quite frequently on our server.
e.g. if the hourly check and the check on start of the build is executed at the same time
damianszczepanik
approved these changes
Jan 30, 2021
|
Good job, thanks! |
theKBro
added a commit
to theKBro/build-history-manager-plugin
that referenced
this pull request
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.