Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed strings when searching for plugin manager version #1939

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

timja
Copy link
Member

@timja timja commented Oct 10, 2024

b95fd98
Found a blog post url with a date because of regex matching

Testing done

tested locally, before:

❯ grep -ilr 2.13.0 ./
.//alpine/hotspot/Dockerfile
.//debian/bookworm-slim/hotspot/Dockerfile
.//debian/bookworm/hotspot/Dockerfile
.//rhel/ubi9/hotspot/Dockerfile
.//docker-bake.hcl
.//README.md
.//windows/windowsservercore/hotspot/Dockerfile

after:

❯ grep -ilrF 2.13.0 ./
.//alpine/hotspot/Dockerfile
.//debian/bookworm-slim/hotspot/Dockerfile
.//debian/bookworm/hotspot/Dockerfile
.//rhel/ubi9/hotspot/Dockerfile
.//docker-bake.hcl
.//windows/windowsservercore/hotspot/Dockerfile

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja requested a review from a team as a code owner October 10, 2024 07:02
@timja timja added the chore label Oct 10, 2024
@timja timja merged commit 9502033 into master Oct 10, 2024
2 of 4 checks passed
@timja timja deleted the timja-patch-1 branch October 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant