From 8ef6fabc479d3a36b3f3c1e554e43182de47672c Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Mon, 26 Aug 2024 06:36:13 -0600 Subject: [PATCH] Fix acceptance tests bny reverting capitalization change The Jenkins acceptance test harness uses the display name to locate UI components and test them. It locates those components by display name. The tests in the acceptance test harness are especially valuable now while we are preparing for the Spring Security 6.x upgrade. It is better to retain the previous capitalization and preserve Jenkins acceptance test harness results rather than need to spread the capitalization change into the acceptance test harness and related components. Added TODO item to fix the capitalization in both the git plugin and the acceptance test harness in a future release. --- .../plugins/git/extensions/impl/SparseCheckoutPaths.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main/java/hudson/plugins/git/extensions/impl/SparseCheckoutPaths.java b/src/main/java/hudson/plugins/git/extensions/impl/SparseCheckoutPaths.java index c5a326a837..a4cb6dc356 100644 --- a/src/main/java/hudson/plugins/git/extensions/impl/SparseCheckoutPaths.java +++ b/src/main/java/hudson/plugins/git/extensions/impl/SparseCheckoutPaths.java @@ -57,7 +57,13 @@ public void determineSupportForJGit(GitSCM scm, @NonNull UnsupportedCommand cmd) public static class DescriptorImpl extends GitSCMExtensionDescriptor { @Override public String getDisplayName() { - return "Sparse checkout paths"; + /* TODO Fix capitalization error here and in Jenkins acceptance test harness. + * + * https://github.com/jenkinsci/acceptance-test-harness/pull/1685#issuecomment-2310075738 + * Acceptance test harness for Git SCM should find components by class instead of by + * display name. Otherwise changes to display name need to be made in ATH and the plugin. + */ + return "Sparse Checkout paths"; } }