From 2be28279a2d588c700f24cb1b6ec4a4f71430824 Mon Sep 17 00:00:00 2001
From: zhangethan <joy__chen@126.com>
Date: Thu, 13 Jul 2023 16:19:39 +0800
Subject: [PATCH] remove useless char "?" at the end of redirect_uri

it's not compatible with gitlab-ce 12.5, gitlab will return 401 when trying to get access_token.
---
 src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java b/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java
index 437d566..583825e 100644
--- a/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java
+++ b/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java
@@ -290,10 +290,9 @@ public HttpResponse doCommenceLogin(StaplerRequest request, @QueryParameter Stri
 
     private String buildRedirectUrl(StaplerRequest request) throws MalformedURLException {
         URL currentUrl = new URL(Jenkins.get().getRootUrl());
-        List<NameValuePair> parameters = new ArrayList<>();
 
         URL redirect_uri = new URL(currentUrl.getProtocol(), currentUrl.getHost(), currentUrl.getPort(),
-                request.getContextPath() + "/securityRealm/finishLogin?" + URLEncodedUtils.format(parameters, StandardCharsets.UTF_8));
+                request.getContextPath() + "/securityRealm/finishLogin");
         return redirect_uri.toString();
     }