Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-54176] Enable the authenticationCache #3694

Closed
wants to merge 1 commit into from
Closed

[JENKINS-54176] Enable the authenticationCache #3694

wants to merge 1 commit into from

Conversation

Wadeck
Copy link
Contributor

@Wadeck Wadeck commented Oct 21, 2018 •
edited
Loading

  • for CLI using remoting with command from @CLIMethod
  • correct the existing test that was no longer "effective" for CLIRegisterer

See JENKINS-54176.

Proposed changelog entries

  • Correct a bug that prevented @CLIMethod (like safe-restart, or keep-build), to load authentication from the cache (populated by login)

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

@Wadeck
[JENKINS-54176] Enable the authenticationCache
1270e6f 
- for CLI using remoting with command from @CLIMethod
fcojfernandez
fcojfernandez approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@fcojfernandez fcojfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wadeck
Copy link
Contributor Author

Wadeck commented Jan 25, 2019

Not sure this PR has still any interest with the removal of remoting proposed by @jglick in #3838

@Wadeck Wadeck added the proposed-for-close There is no consensus about feasibility of this PR, and maintainers do not see a way forward for it label Jan 25, 2019
@jglick
Copy link
Member

jglick commented Jan 28, 2019

I do not suppose we should spend any time fixing bugs in the deprecated mode.

@Wadeck Wadeck closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcojfernandez fcojfernandez fcojfernandez approved these changes

@jvz jvz jvz approved these changes

Assignees
No one assigned
Labels
proposed-for-close There is no consensus about feasibility of this PR, and maintainers do not see a way forward for it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wadeck @jglick @jvz @fcojfernandez