From 312fb8d20861bc7dcc8ea87126c5f742772e0e4b Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Tue, 7 Feb 2023 22:17:34 +0100
Subject: [PATCH 1/9] [JENKINS-60866] Un-inline 'Build Now' JS

---
 .../lib/hudson/project/configurable.jelly     | 13 +++------
 .../hudson/project/configurable/adjunct.js    | 12 +++++++++
 core/src/main/resources/lib/layout/task.jelly | 21 +++++++--------
 .../main/resources/lib/layout/task/task.js    | 27 +++++++++++++++++++
 4 files changed, 53 insertions(+), 20 deletions(-)
 create mode 100644 core/src/main/resources/lib/hudson/project/configurable/adjunct.js
 create mode 100644 core/src/main/resources/lib/layout/task/task.js

diff --git a/core/src/main/resources/lib/hudson/project/configurable.jelly b/core/src/main/resources/lib/hudson/project/configurable.jelly
index 229385112ec8..d15489184503 100644
--- a/core/src/main/resources/lib/hudson/project/configurable.jelly
+++ b/core/src/main/resources/lib/hudson/project/configurable.jelly
@@ -24,17 +24,12 @@ THE SOFTWARE.
 -->
 <?jelly escape-by-default='true'?>
 <!-- Displayed by projects (assignable to ParameterizedJobMixIn.ParameterizedJob) which can be configured and built. -->
-<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout">
+<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:st="jelly:stapler">
     <j:if test="${it.buildable}">
         <j:set var="id" value="${h.generateId()}"/>
-        <l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" onclick="${it.parameterized?null:'return build_' + id + '(this)'}" permission="${it.BUILD}" post="${!it.parameterized}" title="${it.buildNowText}"/>
-        <script>
-            function build_${id}(a) {
-                new Ajax.Request(a.href);
-                hoverNotification('${%Build scheduled}',a.parentNode);
-                return false;
-            }
-        </script>
+        <st:adjunct includes="lib.hudson.project.configurable.adjunct"/>
+        <div id="callback${id}" data-callback="lib_hudson_project_configurable_build_now_callback" data-success="${%Build scheduled}" data-parameterized="${it.parameterized}" />
+        <l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" permission="${it.BUILD}" post="${!it.parameterized}" callbackElementId="callback${id}" title="${it.buildNowText}"/>
     </j:if>
     <j:choose>
         <j:when test="${h.hasPermission(it,it.CONFIGURE)}">
diff --git a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
new file mode 100644
index 000000000000..51502f4e2277
--- /dev/null
+++ b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
@@ -0,0 +1,12 @@
+window["lib_hudson_project_configurable_build_now_callback"] = function (
+  el,
+  ev
+) {
+  let parameterized = el.dataset.parameterized;
+  let success = el.dataset.success;
+  if (parameterized === "false") {
+    new Ajax.Request(ev.target.href);
+    hoverNotification(success, ev.target.parentNode);
+    ev.preventDefault();
+  }
+};
diff --git a/core/src/main/resources/lib/layout/task.jelly b/core/src/main/resources/lib/layout/task.jelly
index 6a63e100f331..89296a277a51 100644
--- a/core/src/main/resources/lib/layout/task.jelly
+++ b/core/src/main/resources/lib/layout/task.jelly
@@ -77,10 +77,18 @@ THE SOFTWARE.
       (onclick supersedes this except in the context menu.)
       (since 1.512)
     </st:attribute>
+    <st:attribute name="onclick" deprecated="true">
+      Onclick inline JS handler. Deprecated, use callbackElementId instead.
+    </st:attribute>
     <st:attribute name="confirmationMessage">
       Message to use for confirmation, if requested; defaults to title.
       (since 1.512)
     </st:attribute>
+    <st:attribute name="callbackElementId">
+      This is the ID attribute of an HTML element that will be looked up to invoke a callback when clicked.
+      The HTML element is expected to have the attribute data-callback (a global function).
+      The global function will be invoked with the HTML element and event as arguments.
+    </st:attribute>
   </st:documentation>
 
   <!--
@@ -149,16 +157,6 @@ THE SOFTWARE.
               <l:icon src="${icon}" />
             </j:set>
             ${taskTags!=null and attrs.contextMenu!='false' ? taskTags.add(href, iconSrc, iconXml, title, post == 'true', requiresConfirmation == 'true') : null}
-            <j:set var="id" value="${h.generateId()}"/>
-            <j:if test="${attrs.onclick == null and post and not requiresConfirmation}">
-                <script>
-                    function postRequest_${id}(a) {
-                        new Ajax.Request(a.href);
-                        hoverNotification('${%Done.}', a.parentNode);
-                        return false;
-                    }
-                </script>
-            </j:if>
 
             <j:choose>
               <j:when test="${requiresConfirmation and not attrs.onClick}">
@@ -171,12 +169,13 @@ THE SOFTWARE.
               </j:when>
 
               <j:otherwise>
-                <a href="${href}" class="task-link ${isCurrent ? 'task-link--active' : ''}" onclick="${attrs.onclick ?: (post ? 'return postRequest_' + id + '(this)' : null)}">
+                <a href="${href}" class="task-link task-link-no-confirm ${isCurrent ? 'task-link--active' : ''}" data-success="${%Done.}" data-post="${attrs.post}" data-callback="${attrs.callbackElementId}" onclick="${attrs.onclick}">
                   <span class="task-icon-link">
                     <l:icon src="${icon}" />
                   </span>
                   <span class="task-link-text">${title}</span>
                 </a>
+                <st:adjunct includes="lib.layout.task.task" />
               </j:otherwise>
             </j:choose>
           </span>
diff --git a/core/src/main/resources/lib/layout/task/task.js b/core/src/main/resources/lib/layout/task/task.js
new file mode 100644
index 000000000000..b78b147a9a00
--- /dev/null
+++ b/core/src/main/resources/lib/layout/task/task.js
@@ -0,0 +1,27 @@
+Behaviour.specify("a.task-link-no-confirm", "task-link", 0, function (el) {
+  if (el.onclick !== null) {
+    return;
+  }
+
+  let post = el.dataset.post;
+  let callbackElementId = el.dataset.callback;
+  let success = el.dataset.success;
+  let href = el.href;
+
+  if (callbackElementId !== undefined) {
+    el.onclick = function (ev) {
+      let callbackElement = document.getElementById(callbackElementId);
+      let callback = callbackElement.dataset.callback;
+      window[callback](callbackElement, ev);
+    };
+    return;
+  }
+
+  if (post === "true") {
+    el.onclick = function (ev) {
+      new Ajax.Request(href);
+      hoverNotification(success, el.parentNode);
+      ev.preventDefault();
+    };
+  }
+});

From 524c4bb36ac126e4064dd85dafa35b856b5617a1 Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Tue, 8 Aug 2023 13:12:40 +0200
Subject: [PATCH 2/9] Fix formatting

---
 .../resources/lib/hudson/project/configurable/adjunct.js    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
index 9ae96e340acc..45a62010d98a 100644
--- a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
+++ b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
@@ -1,12 +1,12 @@
 window["lib_hudson_project_configurable_build_now_callback"] = function (
   el,
-  ev
+  ev,
 ) {
   let parameterized = el.dataset.parameterized;
   let success = el.dataset.success;
   if (parameterized === "false") {
-    fetch(a.href, {
-      method: 'post',
+    fetch(el.href, {
+      method: "post",
       headers: crumb.wrap({}),
     });
     hoverNotification(success, ev.target.parentNode);

From 74e463740844d5f0894830cf37e6a3ecf6c1335b Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Tue, 8 Aug 2023 13:58:27 +0200
Subject: [PATCH 3/9] Use MorphTagLibrary to simplify API

---
 .../lib/hudson/project/configurable.jelly       |  3 +--
 .../lib/hudson/project/configurable/adjunct.js  |  2 +-
 core/src/main/resources/lib/layout/task.jelly   | 13 +++++--------
 core/src/main/resources/lib/layout/task/task.js | 17 +++++++++--------
 4 files changed, 16 insertions(+), 19 deletions(-)

diff --git a/core/src/main/resources/lib/hudson/project/configurable.jelly b/core/src/main/resources/lib/hudson/project/configurable.jelly
index c0bdb8d7ad47..58527c1481ca 100644
--- a/core/src/main/resources/lib/hudson/project/configurable.jelly
+++ b/core/src/main/resources/lib/hudson/project/configurable.jelly
@@ -28,8 +28,7 @@ THE SOFTWARE.
     <j:if test="${it.buildable}">
         <j:set var="id" value="${h.generateId()}"/>
         <st:adjunct includes="lib.hudson.project.configurable.adjunct"/>
-        <div id="callback${id}" data-callback="lib_hudson_project_configurable_build_now_callback" data-success="${%Build scheduled}" data-parameterized="${it.parameterized}" />
-        <l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" permission="${it.BUILD}" post="${!it.parameterized}" callbackElementId="callback${id}" title="${it.buildNowText}"/>
+        <l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" permission="${it.BUILD}" post="${!it.parameterized}" data-callback="lib_hudson_project_configurable_build_now_callback" data-build-success="${%Build scheduled}" data-parameterized="${it.parameterized}" title="${it.buildNowText}"/>
     </j:if>
     <j:choose>
         <j:when test="${h.hasPermission(it,it.CONFIGURE)}">
diff --git a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
index 45a62010d98a..0aa751fd2940 100644
--- a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
+++ b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
@@ -3,7 +3,7 @@ window["lib_hudson_project_configurable_build_now_callback"] = function (
   ev,
 ) {
   let parameterized = el.dataset.parameterized;
-  let success = el.dataset.success;
+  let success = el.dataset.buildSuccess;
   if (parameterized === "false") {
     fetch(el.href, {
       method: "post",
diff --git a/core/src/main/resources/lib/layout/task.jelly b/core/src/main/resources/lib/layout/task.jelly
index 171dbe4162b7..66f97def3dcd 100644
--- a/core/src/main/resources/lib/layout/task.jelly
+++ b/core/src/main/resources/lib/layout/task.jelly
@@ -78,7 +78,9 @@ THE SOFTWARE.
       (since 1.512)
     </st:attribute>
     <st:attribute name="onclick" deprecated="true">
-      Onclick inline JS handler. Deprecated, use callbackElementId instead.
+      Onclick inline JS handler. Deprecated, specify data-callback attribute with the name of a global function instead.
+      It will be called with the 'a' element as first argument, and event as second argument.
+      You can specify further data-* attributes to customize behavior.
     </st:attribute>
     <st:attribute name="badge">
       If set, displays the value as a small badge on the right side of the sidepanel item.
@@ -88,11 +90,6 @@ THE SOFTWARE.
       Message to use for confirmation, if requested; defaults to title.
       (since 1.512)
     </st:attribute>
-    <st:attribute name="callbackElementId" since="TODO">
-      This is the ID attribute of an HTML element that will be looked up to invoke a callback when clicked.
-      The HTML element is expected to have the attribute data-callback (a global function).
-      The global function will be invoked with the HTML element and event as arguments.
-    </st:attribute>
     <st:attribute name="destructive" type="boolean" since="TODO">
       Show red confirmation button.
     </st:attribute>
@@ -186,7 +183,7 @@ THE SOFTWARE.
               </j:when>
 
               <j:otherwise>
-                <a href="${href}" class="task-link task-link-no-confirm ${isCurrent ? 'task-link--active' : ''}" data-success="${%Done.}" data-post="${attrs.post}" data-callback="${attrs.callbackElementId}" onclick="${attrs.onclick}">
+                <m:a xmlns:m="jelly:hudson.util.jelly.MorphTagLibrary" href="${href}" class="task-link task-link-no-confirm ${isCurrent ? 'task-link--active' : ''}" data-task-success="${%Done.}" data-task-post="${attrs.post}" ATTRIBUTES="${attrs}" EXCEPT="field items clazz post permission">
                   <span class="task-icon-link">
                     <l:icon src="${icon}" />
                   </span>
@@ -196,7 +193,7 @@ THE SOFTWARE.
                       ${attrs.badge.text}
                     </span>
                   </j:if>
-                </a>
+                </m:a>
                 <st:adjunct includes="lib.layout.task.task" />
               </j:otherwise>
             </j:choose>
diff --git a/core/src/main/resources/lib/layout/task/task.js b/core/src/main/resources/lib/layout/task/task.js
index b78b147a9a00..5d6fd6fd008c 100644
--- a/core/src/main/resources/lib/layout/task/task.js
+++ b/core/src/main/resources/lib/layout/task/task.js
@@ -3,23 +3,24 @@ Behaviour.specify("a.task-link-no-confirm", "task-link", 0, function (el) {
     return;
   }
 
-  let post = el.dataset.post;
-  let callbackElementId = el.dataset.callback;
-  let success = el.dataset.success;
+  let post = el.dataset.taskPost;
+  let callback = el.dataset.callback;
+  let success = el.dataset.taskSuccess;
   let href = el.href;
 
-  if (callbackElementId !== undefined) {
+  if (callback !== undefined) {
     el.onclick = function (ev) {
-      let callbackElement = document.getElementById(callbackElementId);
-      let callback = callbackElement.dataset.callback;
-      window[callback](callbackElement, ev);
+      window[callback](el, ev);
     };
     return;
   }
 
   if (post === "true") {
     el.onclick = function (ev) {
-      new Ajax.Request(href);
+      fetch(href, {
+        method: "post",
+        headers: crumb.wrap({}),
+      });
       hoverNotification(success, el.parentNode);
       ev.preventDefault();
     };

From 256efbc55586a502f1c52ff5aac6df25108367f4 Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Wed, 9 Aug 2023 12:48:17 +0200
Subject: [PATCH 4/9] Update docs for l:task attributes

---
 core/src/main/resources/lib/layout/task.jelly | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/core/src/main/resources/lib/layout/task.jelly b/core/src/main/resources/lib/layout/task.jelly
index 66f97def3dcd..e68c18fa0fef 100644
--- a/core/src/main/resources/lib/layout/task.jelly
+++ b/core/src/main/resources/lib/layout/task.jelly
@@ -78,9 +78,15 @@ THE SOFTWARE.
       (since 1.512)
     </st:attribute>
     <st:attribute name="onclick" deprecated="true">
-      Onclick inline JS handler. Deprecated, specify data-callback attribute with the name of a global function instead.
-      It will be called with the 'a' element as first argument, and event as second argument.
-      You can specify further data-* attributes to customize behavior.
+      Onclick inline JS handler. Deprecated, specify data-callback attribute instead.
+    </st:attribute>
+    <st:attribute name="data-callback" since="TODO">
+      Name of a global function to call when clicked.
+      It will be called with an element (currently 'a') as first argument, and the event as second argument.
+      You can specify further data-* attributes to customize behavior, those will be defined on the element passed as first argument.
+      Has no effect if you specify the 'requiresConfirmation' attribute.
+      Has no effect on menu items showing in context menus, only 'href', 'post', and 'requiresConfirmation' attributes substantially change behavior there.
+      Set 'contextMenu' to 'false' to remove this task from those menus.
     </st:attribute>
     <st:attribute name="badge">
       If set, displays the value as a small badge on the right side of the sidepanel item.

From 54c6c063ac38bd13356e3119c9e7ba4cd1772255 Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Wed, 9 Aug 2023 14:32:14 +0200
Subject: [PATCH 5/9] This is a collosal waste of time

Copied from 8aee10ea8a1c03c71868bd116e08efa1c9bbc1af, this is just
stupid
---
 .../main/resources/lib/hudson/project/configurable/adjunct.js  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
index 0aa751fd2940..0bb5b8c02c0c 100644
--- a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
+++ b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
@@ -1,6 +1,7 @@
+// prettier-ignore
 window["lib_hudson_project_configurable_build_now_callback"] = function (
   el,
-  ev,
+  ev
 ) {
   let parameterized = el.dataset.parameterized;
   let success = el.dataset.buildSuccess;

From c2a6f0237d029749ce30a8fe97b50f2944d85b0c Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Thu, 10 Aug 2023 09:53:24 +0200
Subject: [PATCH 6/9] Rename adjunct file, restructure to work around broken
 formatter

---
 .../lib/hudson/project/configurable.jelly       |  2 +-
 .../lib/hudson/project/configurable/adjunct.js  | 16 ----------------
 .../hudson/project/configurable/configurable.js | 17 +++++++++++++++++
 3 files changed, 18 insertions(+), 17 deletions(-)
 delete mode 100644 core/src/main/resources/lib/hudson/project/configurable/adjunct.js
 create mode 100644 core/src/main/resources/lib/hudson/project/configurable/configurable.js

diff --git a/core/src/main/resources/lib/hudson/project/configurable.jelly b/core/src/main/resources/lib/hudson/project/configurable.jelly
index 58527c1481ca..ffe5959d8ed6 100644
--- a/core/src/main/resources/lib/hudson/project/configurable.jelly
+++ b/core/src/main/resources/lib/hudson/project/configurable.jelly
@@ -27,7 +27,7 @@ THE SOFTWARE.
 <j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:st="jelly:stapler">
     <j:if test="${it.buildable}">
         <j:set var="id" value="${h.generateId()}"/>
-        <st:adjunct includes="lib.hudson.project.configurable.adjunct"/>
+        <st:adjunct includes="lib.hudson.project.configurable.configurable"/>
         <l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" permission="${it.BUILD}" post="${!it.parameterized}" data-callback="lib_hudson_project_configurable_build_now_callback" data-build-success="${%Build scheduled}" data-parameterized="${it.parameterized}" title="${it.buildNowText}"/>
     </j:if>
     <j:choose>
diff --git a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js b/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
deleted file mode 100644
index 0bb5b8c02c0c..000000000000
--- a/core/src/main/resources/lib/hudson/project/configurable/adjunct.js
+++ /dev/null
@@ -1,16 +0,0 @@
-// prettier-ignore
-window["lib_hudson_project_configurable_build_now_callback"] = function (
-  el,
-  ev
-) {
-  let parameterized = el.dataset.parameterized;
-  let success = el.dataset.buildSuccess;
-  if (parameterized === "false") {
-    fetch(el.href, {
-      method: "post",
-      headers: crumb.wrap({}),
-    });
-    hoverNotification(success, ev.target.parentNode);
-    ev.preventDefault();
-  }
-};
diff --git a/core/src/main/resources/lib/hudson/project/configurable/configurable.js b/core/src/main/resources/lib/hudson/project/configurable/configurable.js
new file mode 100644
index 000000000000..a96e64219502
--- /dev/null
+++ b/core/src/main/resources/lib/hudson/project/configurable/configurable.js
@@ -0,0 +1,17 @@
+(function () {
+  /* The JS formatting rules enforced in this repo can result in function declarations incompatible with HTMLUnit.
+     As a workaround, split function definition and assignment. */
+  function foo(el, ev) {
+    let parameterized = el.dataset.parameterized;
+    let success = el.dataset.buildSuccess;
+    if (parameterized === "false") {
+      fetch(el.href, {
+        method: "post",
+        headers: crumb.wrap({}),
+      });
+      hoverNotification(success, ev.target.parentNode);
+      ev.preventDefault();
+    }
+  }
+  window.lib_hudson_project_configurable_build_now_callback = foo;
+})();

From 7dfa26b225ccbe4080c1cda352bc7c03609cc662 Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Wed, 23 Aug 2023 12:10:18 +0200
Subject: [PATCH 7/9] Exclude all documented attributes except data-*

---
 core/src/main/resources/lib/layout/task.jelly | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/core/src/main/resources/lib/layout/task.jelly b/core/src/main/resources/lib/layout/task.jelly
index e68c18fa0fef..f2341517dc2d 100644
--- a/core/src/main/resources/lib/layout/task.jelly
+++ b/core/src/main/resources/lib/layout/task.jelly
@@ -189,7 +189,14 @@ THE SOFTWARE.
               </j:when>
 
               <j:otherwise>
-                <m:a xmlns:m="jelly:hudson.util.jelly.MorphTagLibrary" href="${href}" class="task-link task-link-no-confirm ${isCurrent ? 'task-link--active' : ''}" data-task-success="${%Done.}" data-task-post="${attrs.post}" ATTRIBUTES="${attrs}" EXCEPT="field items clazz post permission">
+                <m:a xmlns:m="jelly:hudson.util.jelly.MorphTagLibrary"
+                     href="${href}"
+                     class="task-link task-link-no-confirm ${isCurrent ? 'task-link--active' : ''}"
+                     data-task-success="${%Done.}"
+                     data-task-post="${attrs.post}"
+                     ATTRIBUTES="${attrs}"
+                     EXCEPT="badge confirmationMessage contextMenu destructive enabled href icon onclick permission permissions post requiresConfirmation title">
+                  <!-- all documented attributes except data-* are in EXCEPT -->
                   <span class="task-icon-link">
                     <l:icon src="${icon}" />
                   </span>

From a205cc44cd0102de93bef1886811a5527fe626b9 Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Wed, 23 Aug 2023 14:41:10 +0200
Subject: [PATCH 8/9] Fix onclick behavior

---
 core/src/main/resources/lib/layout/task.jelly | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/main/resources/lib/layout/task.jelly b/core/src/main/resources/lib/layout/task.jelly
index f2341517dc2d..3421c2388d9d 100644
--- a/core/src/main/resources/lib/layout/task.jelly
+++ b/core/src/main/resources/lib/layout/task.jelly
@@ -195,8 +195,8 @@ THE SOFTWARE.
                      data-task-success="${%Done.}"
                      data-task-post="${attrs.post}"
                      ATTRIBUTES="${attrs}"
-                     EXCEPT="badge confirmationMessage contextMenu destructive enabled href icon onclick permission permissions post requiresConfirmation title">
-                  <!-- all documented attributes except data-* are in EXCEPT -->
+                     EXCEPT="badge confirmationMessage contextMenu destructive enabled href icon permission permissions post requiresConfirmation title">
+                  <!-- all documented attributes except onclick and data-* are in EXCEPT -->
                   <span class="task-icon-link">
                     <l:icon src="${icon}" />
                   </span>

From 3fc78c52f789d8430c61bfb3e814bdb7183b4465 Mon Sep 17 00:00:00 2001
From: Daniel Beck <daniel-beck@users.noreply.github.com>
Date: Wed, 23 Aug 2023 20:21:18 +0200
Subject: [PATCH 9/9] Address review feedback

---
 core/src/main/resources/lib/hudson/project/configurable.jelly | 1 -
 core/src/main/resources/lib/layout/task.jelly                 | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/resources/lib/hudson/project/configurable.jelly b/core/src/main/resources/lib/hudson/project/configurable.jelly
index ffe5959d8ed6..44bac9b2b9bf 100644
--- a/core/src/main/resources/lib/hudson/project/configurable.jelly
+++ b/core/src/main/resources/lib/hudson/project/configurable.jelly
@@ -26,7 +26,6 @@ THE SOFTWARE.
 <!-- Displayed by projects (assignable to ParameterizedJobMixIn.ParameterizedJob) which can be configured and built. -->
 <j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:st="jelly:stapler">
     <j:if test="${it.buildable}">
-        <j:set var="id" value="${h.generateId()}"/>
         <st:adjunct includes="lib.hudson.project.configurable.configurable"/>
         <l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" permission="${it.BUILD}" post="${!it.parameterized}" data-callback="lib_hudson_project_configurable_build_now_callback" data-build-success="${%Build scheduled}" data-parameterized="${it.parameterized}" title="${it.buildNowText}"/>
     </j:if>
diff --git a/core/src/main/resources/lib/layout/task.jelly b/core/src/main/resources/lib/layout/task.jelly
index 3421c2388d9d..f84ab286302f 100644
--- a/core/src/main/resources/lib/layout/task.jelly
+++ b/core/src/main/resources/lib/layout/task.jelly
@@ -84,6 +84,7 @@ THE SOFTWARE.
       Name of a global function to call when clicked.
       It will be called with an element (currently 'a') as first argument, and the event as second argument.
       You can specify further data-* attributes to customize behavior, those will be defined on the element passed as first argument.
+      See https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dataset for more information about these attributes.
       Has no effect if you specify the 'requiresConfirmation' attribute.
       Has no effect on menu items showing in context menus, only 'href', 'post', and 'requiresConfirmation' attributes substantially change behavior there.
       Set 'contextMenu' to 'false' to remove this task from those menus.