Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting for 2.479.1 (part 3) #9875

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

basil
Copy link
Member

@basil basil commented Oct 15, 2024

Backporting for 2.479.1 (part 3)

Latest core version: Jenkins 2.480

Candidates included

JENKINS-73835           Minor                   2.481
        Builds can be deleted while they are still running
        https://issues.jenkins.io/browse/JENKINS-73835

Backported issues include:

  • JENKINS-73835 Builds can be deleted while they are still running

Testing done

mvn clean verify -DskipTests

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jglick, @dwnusbaum

Before the changes are marked as ready-for-merge:

Maintainer checklist

…l running and ensure build discarders run after builds are fully complete (jenkinsci#9810)

* [JENKINS-73835] Do not allow builds to be deleted while they are still running

* [JENKINS-73835] Avoid redundant calls to Job.logRotate when builds complete and always call Job.logRotate after build finalization

* [JENKINS-73835] Add issue reference to RunTest.buildsMayNotBeDeletedWhileRunning

* [JENKINS-73835] Adjust DeleteBuildsCommandTest.deleteBuildsShouldSuccessEvenTheBuildIsRunning to match new behavior

* [JENKINS-73835] Run/delete.jelly should check Run.isLogUpdated, not Run.isBuilding

(cherry picked from commit d34b17e)
@basil basil added the into-lts This PR is filed against an LTS branch label Oct 15, 2024
…ldIsRunning` so test can be cleaned up on Windows consistently (jenkinsci#9876)

(cherry picked from commit 5019eb9)
@basil basil merged commit 3f43ddf into jenkinsci:stable-2.479 Oct 15, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
into-lts This PR is filed against an LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants