From e3de25119ae350cd765722a609503bd9e01b2a01 Mon Sep 17 00:00:00 2001 From: Basil Crow Date: Wed, 10 Nov 2021 22:07:37 -0800 Subject: [PATCH] Add missing `@Override` annotations --- src/main/java/hudson/util/VersionNumber.java | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/main/java/hudson/util/VersionNumber.java b/src/main/java/hudson/util/VersionNumber.java index 15ef1cf..91142ec 100644 --- a/src/main/java/hudson/util/VersionNumber.java +++ b/src/main/java/hudson/util/VersionNumber.java @@ -88,6 +88,7 @@ private interface Item { */ private static class WildCardItem implements Item { + @Override public int compareTo(Item item) { if (item==null) // 1.* ( > 1.99) > 1 return 1; @@ -103,10 +104,12 @@ public int compareTo(Item item) { } } + @Override public int getType() { return WILDCARD_ITEM; } + @Override public boolean isNull() { return false; } @@ -136,14 +139,17 @@ public IntegerItem(String str) { this.value = new BigInteger(str); } + @Override public int getType() { return INTEGER_ITEM; } + @Override public boolean isNull() { return BigInteger_ZERO.equals(value); } + @Override public int compareTo(Item item) { if (item == null) { return BigInteger_ZERO.equals(value) ? 0 : 1; // 1.0 == 1, 1.1 > 1 @@ -167,6 +173,7 @@ public int compareTo(Item item) { } } + @Override public String toString() { return value.toString(); } @@ -217,10 +224,12 @@ public StringItem(String value, boolean followedByDigit) { this.value = ALIASES.getProperty(value, value); } + @Override public int getType() { return STRING_ITEM; } + @Override public boolean isNull() { return (comparableQualifier(value).compareTo(RELEASE_VERSION_INDEX) == 0); } @@ -241,6 +250,7 @@ public static String comparableQualifier(String qualifier) { return i == -1 ? _QUALIFIERS.size() + "-" + qualifier : String.valueOf(i); } + @Override public int compareTo(Item item) { if (item == null) { // 1-rc < 1, 1-ga > 1 @@ -264,6 +274,7 @@ public int compareTo(Item item) { } } + @Override public String toString() { return value; } @@ -274,10 +285,12 @@ public String toString() { * with '-(number)' in the version specification). */ private static class ListItem extends ArrayList implements Item { + @Override public int getType() { return LIST_ITEM; } + @Override public boolean isNull() { return (size() == 0); } @@ -293,6 +306,7 @@ void normalize() { } } + @Override public int compareTo(Item item) { if (item == null) { if (size() == 0) { @@ -344,6 +358,7 @@ public int compareTo(Item item) { } } + @Override public String toString() { StringBuilder buffer = new StringBuilder("("); for (Iterator iter = iterator(); iter.hasNext(); ) { @@ -459,6 +474,7 @@ private static Item parseItem(boolean isDigit, String buf) { return isDigit ? new IntegerItem(buf) : new StringItem(buf, false); } + @Override public int compareTo(VersionNumber o) { int result = items.compareTo(o.items); if (result != 0) { @@ -483,10 +499,12 @@ public int compareTo(VersionNumber o) { return Integer.compare(i1, i2); } + @Override public String toString() { return value; } + @Override public boolean equals(Object o) { if (!(o instanceof VersionNumber)) { return false; @@ -505,6 +523,7 @@ public boolean equals(Object o) { return snapshot.equals(that.snapshot); } + @Override public int hashCode() { return canonical.hashCode(); } @@ -528,6 +547,7 @@ public boolean isNewerThanOrEqualTo(VersionNumber rhs) { /** * @deprecated see {@link #getDigitAt(int)} */ + @Deprecated public int digit(int idx) { Iterator i = items.iterator(); Item item = i.next();