From 8b8a126591f2fe5d9290ff6eb9cef6def94ef43c Mon Sep 17 00:00:00 2001 From: timja-bot <108958225+timja-bot@users.noreply.github.com> Date: Tue, 6 Jun 2023 09:37:14 +0100 Subject: [PATCH] Upgrade HtmlUnit from 2.x to 3.x (#237) * Upgrade HtmlUnit from 2.x to 3.x * Update pom.xml * Update pom.xml * Update pom.xml --------- Co-authored-by: Tim Jacomb Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> --- pom.xml | 8 ++++---- src/test/java/hudson/tasks/MailerTest.java | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/pom.xml b/pom.xml index 6b2094c..a3a1fb3 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ org.jenkins-ci.plugins plugin - 4.64 + 4.66 @@ -22,7 +22,7 @@ 999999-SNAPSHOT - 2.361.4 + 2.387.3 jenkinsci/${project.artifactId}-plugin true @@ -31,8 +31,8 @@ io.jenkins.tools.bom - bom-2.361.x - 2102.v854b_fec19c92 + bom-2.387.x + 2143.ve4c3c9ec790a import pom diff --git a/src/test/java/hudson/tasks/MailerTest.java b/src/test/java/hudson/tasks/MailerTest.java index dd18dd5..e8eecb3 100644 --- a/src/test/java/hudson/tasks/MailerTest.java +++ b/src/test/java/hudson/tasks/MailerTest.java @@ -23,8 +23,8 @@ */ package hudson.tasks; -import com.gargoylesoftware.htmlunit.html.HtmlForm; -import com.gargoylesoftware.htmlunit.html.HtmlPage; +import org.htmlunit.html.HtmlForm; +import org.htmlunit.html.HtmlPage; import hudson.Functions; import hudson.Launcher; import hudson.model.*; @@ -264,11 +264,11 @@ public void globalConfig() throws Exception { HtmlPage cp = webClient.goTo("configure"); HtmlForm form = cp.getFormByName("config"); - form.getInputByName("_.smtpHost").setValueAttribute("acme.com"); - form.getInputByName("_.defaultSuffix").setValueAttribute("@acme.com"); + form.getInputByName("_.smtpHost").setValue("acme.com"); + form.getInputByName("_.defaultSuffix").setValue("@acme.com"); form.getInputByName("_.authentication").setChecked(true); - form.getInputByName("_.username").setValueAttribute("user"); - form.getInputByName("_.password").setValueAttribute("pass"); + form.getInputByName("_.username").setValue("user"); + form.getInputByName("_.password").setValue("pass"); rule.submit(form);