Require Apache Maven 3.9.6 or later

[Vlatombe]

Previous changes in Maven require 3.9.6 or later for Java 17 compatibility. Fixes #667

See also

• Require Maven 3.9.6 or later pom#612
• Require Maven 3.9.6 or later plugin-pom#1018

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

Thanks! We've been running Apache Maven 3.9.9 and its predecessor versions on ci.jenkins.io and its friends (like release.ci.jenkins.io) since those versions were released. No issues detected as far as I recall.

[basil]

Thanks for the PR! There are a few other places in the ecosystem where we have a 3.8.1 baseline, such as acceptance-test-harness and other Jenkins Maven plugins (e.g., access-modifier-checker). I will try to hunt those down and update them as well.

[basil]

I will try to hunt those down and update them as well.

I moved some of the rest of the ecosystem to Maven 3.9.6 as well. I did not have the time to look at incrementals-tools.

[batmat]

Should this change not be released (would be 3.59 I assume)?
So we can propagate this requirement around, e.g. on https://github.com/jenkinsci/plugin-pom/blob/5485e031ff8f6de66291f02626cd959aba62320f/pom.xml#L77 and https://github.com/jenkinsci/pom/blob/66f86b9fad7fc5112c21055017d40568ce294e15/pom.xml#L98 ?

[Vlatombe]

I don't think it is that urgent, because of jenkinsci/pom#612 & jenkinsci/plugin-pom#1018 doing the same check essentially earlier in the build lifecycle.
Call it defense in depth. Would be only useful if a plugin decides to pick up the latest maven hpi plugin without bumping the parent POM.

However, this makes me think that we could have found out about this issue earlier, if we had a build of maven-hpi-plugin using the minimum maven version that is specified in the build. Under this assumption, I think the plugin ITs would have failed in such an environment.