-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to use csv, xml or yaml file format #19
Comments
Hi @totocaca123, |
or yaml or xml file, these files are quiet similar to json (so a conversion into json would be the simpliest way). For csv/excel, the file format is not clear. This format makes impossible to have multi level. So the simpliest way would be a 1 level chart. Each line is an item and eah column is a field |
I added yaml support with #35. At the moment I have problems with xml conversion. |
implement xml file support with #62 |
@totocaca123 In a cdv file I can not add an
so actually I calculate the id as hashcode of the filename and take the filename as name. At this point, I think it makes sense to completely rebuild the API and set it up like in the warnings-ng plugin, that you have multiple report providers, one for csv with id, name, delimiter, encoding. One for json with id, name, encoding. Etc, something like this:
What do you think about this? |
Yes I agree because CSV file should be simple (columns...) So by removing ID and name, the publish report shall create 1 report with all found files (automatically merge data). |
But then the user have to make sure, that the dataset (1 to n files in pattern) have all the same attributes. Otherwise I can not merge it. So you prefer, that And in each publishReport step all given reports are automatically merged to one as long as the data structure and the ids are the same, otherwise I won't add these reports to the build, so to sum up the api:
With your explanations about the csv we can also support multilevel csv files, that's great, thanks! |
For me the simpliest way is to merge all data from 1 command publishReport (as it is done in warning ng plugin). From my point of view, numbers or report is related to number of call of publishReport. If ID is used, it forces users to create/organize reports inside his data, and number of reports is controlled by json files. I think numbers of reports shall be set by numbers of call. I assume user provide consistent data. In case of unconsistent data, we add numbers of 0 for missing data (with warning message). User has then to improve his data or split data to create 2 reports |
Thanks for your input, I will try something out. But I need an id, otherwise I am not bale to create a history for the history charts at the moment. I will try to implement the new api and have look if there is another way to get rid of the id. |
For the ID, it could be a SHA of report name. The ID could be usefull in pipeline (optional or mandatory?) if user want to be free to change report name without loosing his data. |
What feature do you want to see added?
Support using csv, xml or yaml file format
csv
xml
yaml/yml
would be good but seems that file format has to be basic
Upstream changes
No response
The text was updated successfully, but these errors were encountered: