-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JENKINS_UC_DOWNLOAD_URL if provided #416
base: master
Are you sure you want to change the base?
Use JENKINS_UC_DOWNLOAD_URL if provided #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ok
can you take a look at the tests? |
Happy too, I've no time until weekend probably but will be looking at them then. Wanted to get it raised and review then fix tests. |
Fixing the same issue as highlighted here jenkinsci/docker#1299 |
75c592f
to
8b6bedf
Compare
I've found time. |
8b6bedf
to
a7d7873
Compare
Converting to draft and rebase from PR #417 so this PR easier to understand what has changed when using assertAll to improve dev/test cycles. |
a7d7873
to
4a31145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I ran the tests successfully on my PC with java 11
Fixes #415
The current code ignores JENKINS_UC_DOWNLOAD_URL if specified, as logic above will always result in something else being checked. Other if/else statements might also need to be changed to fix other issues with that logic.