From 50aa17f651d64805d4d9c32dd8fffe2e924b35fe Mon Sep 17 00:00:00 2001
From: Basil Crow <me@basilcrow.com>
Date: Sat, 2 Apr 2022 00:21:53 -0700
Subject: [PATCH] Setting `source` and `target` are unnecessary when setting
 `release`

---
 pom.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/pom.xml b/pom.xml
index 63a49e3..639259a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -844,9 +844,16 @@
         <jdk>[1.9,)</jdk>
       </activation>
       <properties>
+        <!-- When compiling with a Java 9+ compiler, we always rely on "release" in favor of "source" and "target", even when compiling to Java 8 bytecode. -->
         <maven.compiler.release>8</maven.compiler.release>
         <maven.compiler.testRelease>8</maven.compiler.testRelease>
+        <!-- "release" serves the same purpose as Animal Sniffer. -->
         <animal.sniffer.skip>true</animal.sniffer.skip>
+        <!-- While it does not hurt to have these set to the Java specification version, it is also not needed when "release" is in use. -->
+        <maven.compiler.source combine.self="override" />
+        <maven.compiler.target combine.self="override" />
+        <maven.compiler.testSource combine.self="override" />
+        <maven.compiler.testTarget combine.self="override" />
         <!-- Work around openjdk/jdk11u-dev#919. TODO When we upgrade to OpenJDK 11.0.16, this should be deleted. -->
         <maven.compiler.forceJavacCompilerUse>true</maven.compiler.forceJavacCompilerUse>
       </properties>