Skip to content

Commit

Permalink
fix(Settings): Fixes not being able to save custom message
Browse files Browse the repository at this point in the history
see [https://issues.jenkins-ci.org/browse/JENKINS-59503](JENKINS-59503)

If the inline is not present the JSON sent is
"includeCustomMessage":{"customMessage": "testing"}
this cannot be parsed because includeCustomMessage should be a boolean.

When using the inline the JSON is (as expected):
"includeCustomMessage": "true"
"customMessage": "testing"
  • Loading branch information
guilherme93 authored Feb 7, 2020
1 parent c0712bc commit 940eb15
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<f:checkbox name="rawMessage" value="true" checked="${instance.isRawMessage()}"/>
</f:entry>

<f:optionalBlock name="includeCustomMessage" title="Include Custom Message" checked="${instance.includeCustomMessage()}">
<f:optionalBlock name="includeCustomMessage" title="Include Custom Message" inline="true" checked="${instance.includeCustomMessage()}">
<f:entry title="Custom Message">
<f:textarea name="customMessage" value="${instance.getCustomMessage()}"/>
</f:entry>
Expand Down

0 comments on commit 940eb15

Please sign in to comment.