Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Review of the PR #4752 (Add CSS variables - prerequisite for Dark mode) #233

Closed
EstherAF opened this issue Jun 1, 2020 · 4 comments
Closed
Labels
review Reviews for code and documentation changes ui Contributions to Jenkins user interface: enhancements, fixes and UX testing

Comments

@EstherAF
Copy link

EstherAF commented Jun 1, 2020

Review of the PR jenkinsci/jenkins#4752 (Add CSS variables - prerequisite for Dark mode)

Links

@EstherAF EstherAF added the review Reviews for code and documentation changes label Jun 1, 2020
@oleg-nenashev
Copy link
Member

oleg-nenashev commented Jun 1, 2020

Hi @EstherAF . Sorry, but I was unable to find review comments from tyou in this pull request. Could you please clarify the contribution?

@EstherAF
Copy link
Author

EstherAF commented Jun 2, 2020

Hi @EstherAF . Sorry, but I was unable to find review comments from tyou in this pull request. Could you please clarify the contribution?

It is a long PR, indeed 😅 jenkinsci/jenkins#4752 (comment)

@oleg-nenashev
Copy link
Member

You are right, thanks!

@all-contributors please add @EstherAF for reviews

@allcontributors
Copy link
Contributor

@oleg-nenashev

I've put up a pull request to add @EstherAF! 🎉

@oleg-nenashev oleg-nenashev added the ui Contributions to Jenkins user interface: enhancements, fixes and UX testing label Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
review Reviews for code and documentation changes ui Contributions to Jenkins user interface: enhancements, fixes and UX testing
Projects
None yet
Development

No branches or pull requests

2 participants