From 9458af6e44cd7f013cf432a3f4f2a8239c18d134 Mon Sep 17 00:00:00 2001 From: Hannah Mudge Date: Mon, 9 Jan 2023 11:27:56 -0700 Subject: [PATCH] [Dashboard] Add styling to allow clickable TSVB markdown images (#147802) ## Summary After upgrading to [React 17](https://github.com/elastic/kibana/pull/128239), the old version of `react-grid-layout` was no longer compatible and required an upgrade as well. However, this upgrade included a [PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283) that overcame a visual glitch with images, which made it so that a clickable image in TSVB markdown was only clickable in a small region at the bottom of the image. This PR fixes this by undoing the changes made in the aforementioned [PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283) specifically for TSVB markdown images. ### Videos **Before** https://user-images.githubusercontent.com/8698078/208514574-e586c1e0-3675-4ef2-9a42-9956f81dee5a.mov **After** https://user-images.githubusercontent.com/8698078/208514585-353a0413-7ed2-40f9-8e90-8289b5483ecb.mov ### Checklist - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- src/plugins/kibana_react/public/markdown/_markdown.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/kibana_react/public/markdown/_markdown.scss b/src/plugins/kibana_react/public/markdown/_markdown.scss index 3c9b1cd165bab..c11aefe1f4d97 100644 --- a/src/plugins/kibana_react/public/markdown/_markdown.scss +++ b/src/plugins/kibana_react/public/markdown/_markdown.scss @@ -143,6 +143,7 @@ $kbnDefaultFontSize: 14px; max-width: 100%; box-sizing: content-box; border-style: none; + pointer-events: auto; } // 4. Blockquotes