Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change firmware update dowload links to use https instead of http #2491

Closed
MSoegtrop opened this issue Oct 25, 2023 · 5 comments
Closed

Change firmware update dowload links to use https instead of http #2491

MSoegtrop opened this issue Oct 25, 2023 · 5 comments
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component

Comments

@MSoegtrop
Copy link

Describe the issue you are experiencing

Modern web browsers (Firefox since a few years) do not allow to click on http download link - they are completely ignored as if they would not exist. As a result one cannot download firware updates advertised from the dialog box which opens from the start page when there is a firmware update. To actually get the link I had to start the Firefox web debugger, look at the HTML, copy the link, undo the & esacping and paste it to the browser address field.

A simple fix would be to change the adresses to https - I just checked that this does work - exactly the same link just replace http with https. This would also be much safer.

Describe the behavior you expected

I can download a firmware update by clicking on the link in the browser.

Steps to reproduce the issue

You need a device with outdated firmware.
Then in the start screen a message Geräte-Update: | Neue Geräte-Firmware verfügbar (1) appears
Click on this message -> a dialog box appears with a firmware download link
Click on this firmware download link -> in Firefox nothing happens (not even a warning)

What is the version this bug report is based on?

3.71.12.20231020

Which base platform are you running?

rpi3 (RaspberryPi3)

Which HomeMatic/homematicIP radio module are you using?

HM-MOD-RPI-PCB

Anything in the logs that might be useful for us?

Shouldn't be relevant.

Additional information

I am using an original CCU3 and I am running Raspberry Matic under Home Assistant version 11.0 - I am just using a larger and faster SD card (64 GB). RAM is tight but fine - I am running at 70..80% with a few other integrations (Fritzbox, SMA). I am not sure people know that this actually works - I found some discussions on the internet* which suggest it doesn't. In case there is interest, I could write a report on this.

@MSoegtrop MSoegtrop added the 🐛 bug-report Something isn't working label Oct 25, 2023
@jens-maus jens-maus added the 🙅 worksforme This isn't reproducible by the maintainer label Oct 25, 2023
@github-actions
Copy link
Contributor

@MSoegtrop, the issue you reported does not seem to be reproducible by the maintainer of this project. Please provide additional information and more detail and please try to reproduce your problem with a fresh test installation and try to find other users having the same problems so that they can support your observations.

@jens-maus
Copy link
Owner

Sorry, but I cannot reproduce this issue here in a RaspberryMatic standalone installation. In addition, I can perfectly see that the device download URL are always https:// URLs. I also tried this in different browser like Chrome and Firefox and didn't note any issue here. See here for the browser console where you can see that the URL is perfectly a https URL:

Bildschirmfoto 2023-10-25 um 09 33 04

So please elaborate further as I think this might be a HomeAssistant Addon issue only and try to identify the root cause by using your browser console and debugging.

@jens-maus
Copy link
Owner

Ok, after some further investigation, I think I have found the reason why this does not work for you. The issue seems to be that you might access home assistant via https, but the internal ingress based access to the WebUI is using plain http for performance reasons. But unfortunately the WebUI has some logic to identify if a connection is running under http or https, thus it will present plain http download links in that case but your main home assistant webui is running https, thus this will end up in that cross-security issue which some browsers simply don't like (having external http links in a https page).

@jens-maus jens-maus added 🏷️ WebUI This refs the WebUI component and removed 🙅 worksforme This isn't reproducible by the maintainer labels Oct 25, 2023
@jens-maus jens-maus added this to the next release milestone Oct 25, 2023
@jens-maus jens-maus moved this to In progress in WebUI improvements/fixes Oct 25, 2023
@jens-maus jens-maus moved this from In progress to Done in WebUI improvements/fixes Oct 25, 2023
@MSoegtrop
Copy link
Author

@jens-maus : thanks for the investigations - more complicated than I thought. Would it make sense to always use https for firmware downloads? Since this goes to the internet - unlike usually local access to the WebUI - it would make sense from a security point of view to use https even if the WebUI uses http. Performance should not be relevant for such a download.

@jens-maus
Copy link
Owner

Already done, this ticket is closed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
Development

No branches or pull requests

2 participants