Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruby 2.2 #40

Closed
ghost opened this issue Apr 15, 2015 · 9 comments
Closed

Support ruby 2.2 #40

ghost opened this issue Apr 15, 2015 · 9 comments

Comments

@ghost
Copy link

ghost commented Apr 15, 2015

I guess this may be caused by the ruby_parser dependency not supporting 2.2?

Error reading triggers in db/migrate/20150415070431_create_trigger_user_update.rb: unrecognized RUBY_VERSION 2.2.0

@jenseng
Copy link
Owner

jenseng commented Apr 15, 2015

Yeah, unfortunately even the latest ruby_parser still just supports 2.1. This might be a good time to investigate swapping it out for parser, which does support 2.2 ... I've been meaning to check it out for a while now.

@ghost
Copy link
Author

ghost commented Apr 15, 2015

For anyone with the same issue, here's a nasty monkey patch which works for now, based on someone else's earlier patch when the same issue happened with Ruby 2.1:

If you're using Rails, you can put this in config/initializers/overrides.rb

require 'ruby_parser'

# Monkey patch to support Ruby 2.2
RubyParser.class_eval do
  def self.for_current_ruby
    Ruby21Parser.new
  end
end

@jtippett
Copy link

+1 to this, but I do note that ruby_parser seems to be inching towards supporting 2.2

@monkbroc
Copy link

FYI, I installed hair_trigger in an app with Ruby 2.2.1 and its working fine. Bundler pulled in ruby_parser 3.7.0 which has preliminary support for Ruby 2.2. It seems to be enough.

Do you want to close this issue @jenseng?

@jenseng
Copy link
Owner

jenseng commented Aug 5, 2015

i'll bump the ruby_parser dependency and then close this out. thanks :)

@mockdeep
Copy link

Bump on this. It's blocking us upgrading to Ruby 2.2.

@jenseng
Copy link
Owner

jenseng commented Dec 16, 2015

dang, I spaced on this on in the last hairtrigger release /o\ ... stand by

@jenseng
Copy link
Owner

jenseng commented Dec 16, 2015

ruby_parser dependency has been bumped in v0.2.17

@mockdeep
Copy link

Great, thanks! Will give that a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants