Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect GLFs #58

Open
jerch opened this issue Sep 18, 2022 · 0 comments
Open

respect GLFs #58

jerch opened this issue Sep 18, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@jerch
Copy link
Owner

jerch commented Sep 18, 2022

The size calculation is off in several ways (see jerch/xterm-addon-image#37 for details).

Basically we should not strip empty sixel bands at all, but account them in size calculation. This kinda contradict the idea to get the smallest area of pixels touched by sixels in a sense of image dimensions, thus needs some fundamental rework of how the decoder propagates the result.

Possible ideas:

  1. introduce a more low level interface directly working on band level and let the consumer decide whether to turn them into a big image blob or keep them as stripes
  2. keep main image like logic intact, but announce additionally sixel cursor moves from GLFs
  3. draw more directly on canvas, e.g. provide an interface for hooking a canvas (slices) to directly draw on (would also solve the composition/overdraw issue currently lacking in the xterm.js addon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant